From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=46922 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pfy0Q-0004Db-Cn for qemu-devel@nongnu.org; Thu, 20 Jan 2011 12:09:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pfy0L-0002ys-8m for qemu-devel@nongnu.org; Thu, 20 Jan 2011 12:09:02 -0500 Received: from moutng.kundenserver.de ([212.227.17.9]:64549) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pfy0K-0002yV-Nc for qemu-devel@nongnu.org; Thu, 20 Jan 2011 12:09:01 -0500 Message-ID: <4D386C26.5070007@mail.berlios.de> Date: Thu, 20 Jan 2011 18:08:54 +0100 From: Stefan Weil MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 1/5] Fast Virtual Disk (FVD) Proposal Part 1 References: <1295474688-6219-1-git-send-email-ctang@us.ibm.com> <20110120130140.GA8143@lst.de> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chunqiang Tang Cc: Christoph Hellwig , qemu-devel@nongnu.org Am 20.01.2011 15:49, schrieb Chunqiang Tang: >> Please try to split the patches into logical parts, and use descriptive >> subject lines for each patch. >> E.g. adding the new sim command to qemu-io could be one patch, adding >> the img_update (why not just update?) command to qemu-img another, >> moving code into qemu-tool-time.c one more, etc. > > Will do and thank you for the detailed instructions. > >>> - >>> + >> Please do not introduce random whitespace changes in patches. > > Stefan Weil previously suggested removing spaces at the end of a line, > and > I used a script to do that. It seems that in this example, the old code > has multiple spaces on an empty line, which were automatically removed by > the script. Yes, that's a problem with some parts of the old code. For files which you want to modify, you could remove the spaces with your script before applying your other modifications and create a separate patch which only removes the superfluous spaces. So your patch series would start with patches which only remove spaces at line endings (and say so in the patch descriptions). Then these changes are no longer random whitespace changes. Regards, Stefan Weil