From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=38797 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PgG51-0005bB-59
	for qemu-devel@nongnu.org; Fri, 21 Jan 2011 07:27:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1PgG4z-0006dR-Bb
	for qemu-devel@nongnu.org; Fri, 21 Jan 2011 07:27:02 -0500
Received: from mx1.redhat.com ([209.132.183.28]:45144)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1PgG4z-0006dF-2B
	for qemu-devel@nongnu.org; Fri, 21 Jan 2011 07:27:01 -0500
Message-ID: <4D397BD8.70901@redhat.com>
Date: Fri, 21 Jan 2011 13:28:08 +0100
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1295607609-21091-1-git-send-email-stefanha@linux.vnet.ibm.com>
In-Reply-To: <1295607609-21091-1-git-send-email-stefanha@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH v3 0/4] usb-msd: Add usb-storage,
	removable=on|off property
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org, "Justin M. Forbes" <jforbes@redhat.com>, Christoph Hellwig <hch@lst.de>

Am 21.01.2011 12:00, schrieb Stefan Hajnoczi:
> Allow overriding the SCSI INQUIRY removable (RMB) bit for scsi-disk and usb-msd
> devices.  In particular this addresses the problem that some usb-msd devices
> have the bit set while other do not have it set.  Now the user can choose and
> get desired guest behavior.
> 
> qemu -usb
>      -drive if=none,file=test.img,cache=none,id=disk0
>      -device usb-storage,drive=disk0,removable=on
> 
> The default is off.
> 
> v3:
>  * Document removable property in qdev-device-use.txt
>  * Use bit number 0 instead of bit 1 for the qdev property
> 
> v2:
>  * Rewritten to override the bit at the scsi-disk level
> 
>  docs/qdev-device-use.txt |   13 +++++++++++--
>  hw/pci-hotplug.c         |    2 +-
>  hw/scsi-bus.c            |    8 ++++++--
>  hw/scsi-disk.c           |    3 +++
>  hw/scsi.h                |    3 ++-
>  hw/usb-msd.c             |    4 +++-
>  6 files changed, 26 insertions(+), 7 deletions(-)

Thanks, applied all to the block branch.

Kevin