From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=41134 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PgI1q-0002bg-SN
	for qemu-devel@nongnu.org; Fri, 21 Jan 2011 09:31:56 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1PgI1p-0000B4-95
	for qemu-devel@nongnu.org; Fri, 21 Jan 2011 09:31:54 -0500
Received: from mx1.redhat.com ([209.132.183.28]:37567)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1PgI1p-0000Az-2R
	for qemu-devel@nongnu.org; Fri, 21 Jan 2011 09:31:53 -0500
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id p0LEVpcP016737
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 21 Jan 2011 09:31:51 -0500
Message-ID: <4D399933.3030306@redhat.com>
Date: Fri, 21 Jan 2011 15:33:23 +0100
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1295289090-18236-1-git-send-email-armbru@redhat.com>
	<1295289090-18236-4-git-send-email-armbru@redhat.com>
In-Reply-To: <1295289090-18236-4-git-send-email-armbru@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 3/5] blockdev: Reject multiple definitions
 for the same drive
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org

Am 17.01.2011 19:31, schrieb Markus Armbruster:
> For reasons lost in the mist of time, we silently ignore multiple
> definitions for the same drive:
> 
>     $ qemu-system-x86_64 -nodefaults -vnc :1 -S -monitor stdio -drive if=ide,index=1,file=tmp.qcow2 -drive if=ide,index=1,file=nonexistant
>     QEMU 0.13.50 monitor - type 'help' for more information
>     (qemu) info block
>     ide0-hd1: type=hd removable=0 file=tmp.qcow2 backing_file=tmp.img ro=0 drv=qcow2 encrypted=0
> 
> With if=none, this can become quite confusing:
> 
>     $ qemu-system-x86_64 -nodefaults -vnc :1 -S -monitor stdio -drive if=none,index=1,file=tmp.qcow2,id=eins -drive if=none,index=1,file=nonexistant,id=zwei -device ide-drive,drive=eins -device ide-drive,drive=zwei
>     qemu-system-x86_64: -device ide-drive,drive=zwei: Property 'ide-drive.drive' can't find value 'zwei'
> 
> The second -device fails, because it refers to drive zwei, which got
> silently ignored.
> 
> Make multiple drive definitions fail cleanly.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>

Dropped this one (and patch 5, which depends on it) from the block
branch again, it breaks -cdrom and probably other drives which are
created by default.

Kevin