From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=37136 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PgK0E-00078y-QD
	for qemu-devel@nongnu.org; Fri, 21 Jan 2011 11:38:23 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1PgK0D-00018i-LU
	for qemu-devel@nongnu.org; Fri, 21 Jan 2011 11:38:22 -0500
Received: from mx1.redhat.com ([209.132.183.28]:23204)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1PgK0D-00018J-Eo
	for qemu-devel@nongnu.org; Fri, 21 Jan 2011 11:38:21 -0500
Message-ID: <4D39B668.4040806@redhat.com>
Date: Fri, 21 Jan 2011 17:38:00 +0100
From: Jes Sorensen <Jes.Sorensen@redhat.com>
MIME-Version: 1.0
References: <1295270117-24760-1-git-send-email-mdroth@linux.vnet.ibm.com>
	<1295270117-24760-8-git-send-email-mdroth@linux.vnet.ibm.com>
In-Reply-To: <1295270117-24760-8-git-send-email-mdroth@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [RFC][PATCH v6 07/23] virtagent: base server
	definitions
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Roth <mdroth@linux.vnet.ibm.com>
Cc: agl@linux.vnet.ibm.com, stefanha@linux.vnet.ibm.com, abeekhof@redhat.com, marcel.mittelstaedt@de.ibm.com, qemu-devel@nongnu.org, aliguori@linux.vnet.ibm.com, ryanh@us.ibm.com, markus_mueller@de.ibm.com

> diff --git a/virtagent-server.h b/virtagent-server.h
> new file mode 100644
> index 0000000..9f68921
> --- /dev/null
> +++ b/virtagent-server.h
> @@ -0,0 +1,34 @@
> +/*
> + * virt-agent - host/guest RPC daemon functions
> + *
> + * Copyright IBM Corp. 2010
> + *
> + * Authors:
> + *  Michael Roth      <mdroth@linux.vnet.ibm.com>
> + *
> + * This work is licensed under the terms of the GNU GPL, version 2 or later.
> + * See the COPYING file in the top-level directory.
> + *
> + */
> +
> +#include <xmlrpc-c/base.h>
> +#include <xmlrpc-c/server.h>
> +
> +#define GUEST_AGENT_SERVICE_ID "virtagent"
> +#define GUEST_AGENT_PATH "/tmp/virtagent-guest.sock"
> +#define HOST_AGENT_SERVICE_ID "virtagent-host"
> +#define HOST_AGENT_PATH "/tmp/virtagent-host.sock"
> +#define VA_GETFILE_MAX 1 << 30
> +#define VA_FILEBUF_LEN 16384
> +#define VA_DMESG_LEN 16384

I really don't like these hard coded constants - you you have a command
line interface allowing for the change of the sockets and file names?
Otherwise you'll hit problems on the host side with concurrent runs of qemu.

I really would like to see the dmesg stuff removed too for now as we
discussed earlier.

Cheers,
Jes