From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=36305 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PgLDV-0003Rw-2O for qemu-devel@nongnu.org; Fri, 21 Jan 2011 12:56:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PgLDT-0004Gh-SM for qemu-devel@nongnu.org; Fri, 21 Jan 2011 12:56:08 -0500 Received: from e37.co.us.ibm.com ([32.97.110.158]:41912) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PgLDT-0004GK-N2 for qemu-devel@nongnu.org; Fri, 21 Jan 2011 12:56:07 -0500 Received: from d03relay03.boulder.ibm.com (d03relay03.boulder.ibm.com [9.17.195.228]) by e37.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id p0LHrPDK027698 for ; Fri, 21 Jan 2011 10:53:25 -0700 Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d03relay03.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p0LHtrDB097804 for ; Fri, 21 Jan 2011 10:55:53 -0700 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p0LHtqs4032277 for ; Fri, 21 Jan 2011 10:55:53 -0700 Message-ID: <4D39C8A6.7000404@linux.vnet.ibm.com> Date: Fri, 21 Jan 2011 11:55:50 -0600 From: Michael Roth MIME-Version: 1.0 References: <1295270117-24760-1-git-send-email-mdroth@linux.vnet.ibm.com> <1295270117-24760-8-git-send-email-mdroth@linux.vnet.ibm.com> <4D39B668.4040806@redhat.com> In-Reply-To: <4D39B668.4040806@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [RFC][PATCH v6 07/23] virtagent: base server definitions List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jes Sorensen Cc: agl@linux.vnet.ibm.com, stefanha@linux.vnet.ibm.com, abeekhof@redhat.com, marcel.mittelstaedt@de.ibm.com, qemu-devel@nongnu.org, aliguori@linux.vnet.ibm.com, ryanh@us.ibm.com, markus_mueller@de.ibm.com On 01/21/2011 10:38 AM, Jes Sorensen wrote: >> diff --git a/virtagent-server.h b/virtagent-server.h >> new file mode 100644 >> index 0000000..9f68921 >> --- /dev/null >> +++ b/virtagent-server.h >> @@ -0,0 +1,34 @@ >> +/* >> + * virt-agent - host/guest RPC daemon functions >> + * >> + * Copyright IBM Corp. 2010 >> + * >> + * Authors: >> + * Michael Roth >> + * >> + * This work is licensed under the terms of the GNU GPL, version 2 or later. >> + * See the COPYING file in the top-level directory. >> + * >> + */ >> + >> +#include >> +#include >> + >> +#define GUEST_AGENT_SERVICE_ID "virtagent" >> +#define GUEST_AGENT_PATH "/tmp/virtagent-guest.sock" >> +#define HOST_AGENT_SERVICE_ID "virtagent-host" >> +#define HOST_AGENT_PATH "/tmp/virtagent-host.sock" >> +#define VA_GETFILE_MAX 1<< 30 >> +#define VA_FILEBUF_LEN 16384 >> +#define VA_DMESG_LEN 16384 > > I really don't like these hard coded constants - you you have a command > line interface allowing for the change of the sockets and file names? > Otherwise you'll hit problems on the host side with concurrent runs of qemu. Yup, that's one of the TODOs. In terms of configuration we can add parameters to the chardev to override these, but the goal here is sane defaults to avoid unnecessarily complicated invocations. > > I really would like to see the dmesg stuff removed too for now as we > discussed earlier. I think as a development/support tool it has a recently strong use case, even given it's limitations (which are not so bad....we retrieve up to a max of 16KB, possibly less depending on guest configuration, so it's not entirely predictable, but it's not dangerous. It's platform-specific, but that's handled by capabilities negotiation). I just don't really see the downside to keeping it in. > > Cheers, > Jes