From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=38575 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Ph9K4-00006x-RJ
	for qemu-devel@nongnu.org; Sun, 23 Jan 2011 18:26:17 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Ph9K3-0001xt-Q7
	for qemu-devel@nongnu.org; Sun, 23 Jan 2011 18:26:16 -0500
Received: from mail-yx0-f173.google.com ([209.85.213.173]:60728)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Ph9K3-0001xm-Kk
	for qemu-devel@nongnu.org; Sun, 23 Jan 2011 18:26:15 -0500
Received: by yxl31 with SMTP id 31so1269252yxl.4
	for <qemu-devel@nongnu.org>; Sun, 23 Jan 2011 15:26:14 -0800 (PST)
Message-ID: <4D3CB90C.8020702@codemonkey.ws>
Date: Sun, 23 Jan 2011 17:26:04 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 2/3] FVD: Added the simulated 'blksim' driver
References: <1295648355-17359-1-git-send-email-ctang@us.ibm.com>	<1295648355-17359-2-git-send-email-ctang@us.ibm.com>	<4D3A0D5C.3080603@codemonkey.ws>
	<OFD60FB7DB.A56C3EBE-ON85257820.001120A2-85257820.0011375A@us.ibm.com>
In-Reply-To: <OFD60FB7DB.A56C3EBE-ON85257820.001120A2-85257820.0011375A@us.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Chunqiang Tang <ctang@us.ibm.com>
Cc: qemu-devel@nongnu.org

On 01/21/2011 09:09 PM, Chunqiang Tang wrote:
>> Coding style.
>>
>> In general, I like the idea of the simulator but the coding style is off
>>      
>    
>> quite a bit.
>>      
> Please be specific and I would be happy to take suggestions. The header
> issue should be easy to fix.
>    

Read CODING_STYLE and go through your code.

The code pretty consistently doesn't follow it.

Regards,

Anthony Liguori