From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=38866 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Ph9LW-0000pW-W1
	for qemu-devel@nongnu.org; Sun, 23 Jan 2011 18:27:47 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Ph9LV-00028Q-T6
	for qemu-devel@nongnu.org; Sun, 23 Jan 2011 18:27:46 -0500
Received: from mail-gy0-f173.google.com ([209.85.160.173]:64004)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Ph9LV-00028M-PC
	for qemu-devel@nongnu.org; Sun, 23 Jan 2011 18:27:45 -0500
Received: by gye5 with SMTP id 5so1262881gye.4
	for <qemu-devel@nongnu.org>; Sun, 23 Jan 2011 15:27:45 -0800 (PST)
Message-ID: <4D3CB968.30604@codemonkey.ws>
Date: Sun, 23 Jan 2011 17:27:36 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1/5] Fast Virtual Disk (FVD) Proposal Part 1
References: <1295474688-6219-1-git-send-email-ctang@us.ibm.com>	<4D3A0B7C.3000007@codemonkey.ws>
	<OF597E7FEB.0778ECE2-ON85257820.000F2AF9-85257820.000F9B47@us.ibm.com>
In-Reply-To: <OF597E7FEB.0778ECE2-ON85257820.000F2AF9-85257820.000F9B47@us.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Chunqiang Tang <ctang@us.ibm.com>
Cc: qemu-devel@nongnu.org

On 01/21/2011 08:51 PM, Chunqiang Tang wrote:
>>> -void qemu_bh_schedule(QEMUBH *bh)
>>> -{
>>> -    bh->cb(bh->opaque);
>>> -}
>>> -
>>> -void qemu_bh_cancel(QEMUBH *bh)
>>> -{
>>> -}
>>> -
>>> -void qemu_bh_delete(QEMUBH *bh)
>>> -{
>>> -    qemu_free(bh);
>>> -}
>>> -
>>>    int qemu_set_fd_handler2(int fd,
>>>                             IOCanReadHandler *fd_read_poll,
>>>                             IOHandler *fd_read,
>>>
>>>        
>> These functions surely cannot just be deleted like this.
>>      
> These functions were not deleted but instead moved into a separate file
> qemu-tool-time.c, because those functions are time related and the
> implementations are different in the simulation mode and in the real mode.
> In the latest patches, these functions are kept in qemu-tool.c but their
> implementations support both cases based on a switch.
>    

I think the root of the problem is that your series didn't maintain 
bisectability.

IOW, each patch needs to be able to be applied one at a time such that 
at each point, the build doesn't break and functionality doesn't break.

Otherwise, tools like git bisect don't work.

Regards,

Anthony Liguori