qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
	qemu-devel@nongnu.org, xudong <706766@bugs.launchpad.net>
Subject: [Qemu-devel] Re: [PATCH] block: Use backing format driver during image creation
Date: Mon, 24 Jan 2011 10:53:58 +0100	[thread overview]
Message-ID: <4D3D4C36.7050709@redhat.com> (raw)
In-Reply-To: <1295861540-28423-1-git-send-email-stefanha@linux.vnet.ibm.com>

On 01/24/11 10:32, Stefan Hajnoczi wrote:
> The backing format should be honored during image creation.  For some
> reason we currently use the image format to open the backing file.  This
> fails when the backing file has a different format than the image being
> created.  Keep the image and backing format drivers completely separate.
> 
> Also print the backing filename if there is an error opening the backing
> file instead of the image filename.
> 
> Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
> ---
>  block.c |    8 +++++---
>  1 files changed, 5 insertions(+), 3 deletions(-)
> 

Looks good!

Acked-by: Jes Sorensen <Jes.Sorensen@redhat.com>

  reply	other threads:[~2011-01-24  9:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-24  9:32 [Qemu-devel] [PATCH] block: Use backing format driver during image creation Stefan Hajnoczi
2011-01-24  9:53 ` Jes Sorensen [this message]
2011-01-24 10:31 ` [Qemu-devel] " Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D3D4C36.7050709@redhat.com \
    --to=jes.sorensen@redhat.com \
    --cc=706766@bugs.launchpad.net \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).