From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=55004 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PhJ7j-00028s-69 for qemu-devel@nongnu.org; Mon, 24 Jan 2011 04:54:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PhJ7i-00074B-07 for qemu-devel@nongnu.org; Mon, 24 Jan 2011 04:54:10 -0500 Received: from mx1.redhat.com ([209.132.183.28]:29683) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PhJ7h-00073z-KF for qemu-devel@nongnu.org; Mon, 24 Jan 2011 04:54:09 -0500 Message-ID: <4D3D4C36.7050709@redhat.com> Date: Mon, 24 Jan 2011 10:53:58 +0100 From: Jes Sorensen MIME-Version: 1.0 References: <1295861540-28423-1-git-send-email-stefanha@linux.vnet.ibm.com> In-Reply-To: <1295861540-28423-1-git-send-email-stefanha@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] block: Use backing format driver during image creation List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Kevin Wolf , qemu-devel@nongnu.org, xudong <706766@bugs.launchpad.net> On 01/24/11 10:32, Stefan Hajnoczi wrote: > The backing format should be honored during image creation. For some > reason we currently use the image format to open the backing file. This > fails when the backing file has a different format than the image being > created. Keep the image and backing format drivers completely separate. > > Also print the backing filename if there is an error opening the backing > file instead of the image filename. > > Signed-off-by: Stefan Hajnoczi > --- > block.c | 8 +++++--- > 1 files changed, 5 insertions(+), 3 deletions(-) > Looks good! Acked-by: Jes Sorensen