From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=41809 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PhOkI-0003Ys-6A
	for qemu-devel@nongnu.org; Mon, 24 Jan 2011 10:54:24 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1PhOkF-0006ux-W1
	for qemu-devel@nongnu.org; Mon, 24 Jan 2011 10:54:21 -0500
Received: from mx1.redhat.com ([209.132.183.28]:20582)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1PhOkF-0006ul-PC
	for qemu-devel@nongnu.org; Mon, 24 Jan 2011 10:54:19 -0500
Message-ID: <4D3DA0F7.1000104@redhat.com>
Date: Mon, 24 Jan 2011 16:55:35 +0100
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1295883301-7278-1-git-send-email-stefanha@linux.vnet.ibm.com>
In-Reply-To: <1295883301-7278-1-git-send-email-stefanha@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH v4 0/4] usb-msd: Add usb-storage,
	removable=on|off property
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Cc: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org, "Justin M. Forbes" <jforbes@redhat.com>, Christoph Hellwig <hch@lst.de>

Am 24.01.2011 16:34, schrieb Stefan Hajnoczi:
> Allow overriding the SCSI INQUIRY removable (RMB) bit for scsi-disk and usb-msd
> devices.  In particular this addresses the problem that some usb-msd devices
> have the bit set while other do not have it set.  Now the user can choose and
> get desired guest behavior.
> 
> qemu -usb
>     -drive if=none,file=test.img,cache=none,id=disk0
>     -device usb-storage,drive=disk0,removable=on
> 
> The default is off.
> 
> v4:
>  * Explicitly state that scsi-generic does not support the removable bit override
>  * Try to make the scsi_bus_legacy_add_drive() commit description clearer
> 
> v3:
>  * Document removable property in qdev-device-use.txt
>  * Use bit number 0 instead of bit 1 for the qdev property
> 
> v2:
>  * Rewritten to override the bit at the scsi-disk level
> 

Thanks, updated the patches in the block branch.

Kevin