Re: [Qemu-devel] Re: [PATCH v4 0/4] strtosz() cleanups

[Stefan Weil <weil@mail.berlios.de>]

Am 24.01.2011 16:45, schrieb Kevin Wolf:
> Am 24.01.2011 16:33, schrieb Jes.Sorensen@redhat.com:
>> From: Jes Sorensen <Jes.Sorensen@redhat.com>
>>
>> Hi,
>>
>> Here is an updated version of the strtosz() fixes that were discussed
>> earlier. Per discussing with Anthony on irc, he is ok with them going
>> in like this.
>>
>> This is a respin to fix a patch conflict in the block tree, and it
>> pulls the two patch sets into one set of four patches instead. No
>> functional change.
>>
>> Cheers,
>> Jes
>>
>>
>> Jes Sorensen (4):
>> strtosz(): use unsigned char and switch to qemu_isspace()
>> strtosz() use qemu_toupper() to simplify switch statement
>> strtosz(): Fix name confusion in use of modf()
>> strtosz(): Use suffix macros in switch() statement
>>
>> cutils.c | 28 ++++++++++++----------------
>> 1 files changed, 12 insertions(+), 16 deletions(-)
>>
>
> Thanks, applied all to the block branch.
>
> Kevin

There was some discussion regarding this patch set.
I agree with Markus that part of the first patch
should be removed: don't change char to unsigned char.

It's not necessary, and the result is, that now unsigned chars
are assigned to chars which might raise future compiler
warnings.

Stefan