From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=53988 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PhQom-0006xk-Fy
	for qemu-devel@nongnu.org; Mon, 24 Jan 2011 13:07:09 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1PhQoj-0003Lv-SD
	for qemu-devel@nongnu.org; Mon, 24 Jan 2011 13:07:08 -0500
Received: from moutng.kundenserver.de ([212.227.17.10]:51296)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1PhQoj-0003Ll-EV
	for qemu-devel@nongnu.org; Mon, 24 Jan 2011 13:07:05 -0500
Received: from localhost ([127.0.0.1] ident=stefan)
	by flocke.fritz.box with esmtp (Exim 4.72)
	(envelope-from <weil@mail.berlios.de>) id 1PhQoh-0001Zl-4F
	for qemu-devel@nongnu.org; Mon, 24 Jan 2011 19:07:03 +0100
Message-ID: <4D3DBFC7.4060103@mail.berlios.de>
Date: Mon, 24 Jan 2011 19:07:03 +0100
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
References: <1295890808-5447-1-git-send-email-weil@mail.berlios.de>
In-Reply-To: <1295890808-5447-1-git-send-email-weil@mail.berlios.de>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] HACKING: Update status of format checking
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: QEMU Developers <qemu-devel@nongnu.org>

Am 24.01.2011 18:40, schrieb Stefan Weil:
> Hopefully all functions with printf like arguments now use format checking.
>
> This was tested with default build configuration on linux
> and windows hosts (including some cross compilations),
> so chances are good that there remain few (if any) functions
> without format checking.
>
> Therefore the last comment in HACKING is no longer valid but misleading.
>
> Cc: Blue Swirl<blauwirbel@gmail.com>
> Signed-off-by: Stefan Weil<weil@mail.berlios.de>
> ---
>   HACKING |    3 ---
>   1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/HACKING b/HACKING
> index 6ba9d7e..3af53fd 100644
> --- a/HACKING
> +++ b/HACKING
> @@ -120,6 +120,3 @@ gcc's printf attribute directive in the prototype.
>   This makes it so gcc's -Wformat and -Wformat-security options can do
>   their jobs and cross-check format strings with the number and types
>   of arguments.
> -
> -Currently many functions in QEMU are not following this rule but
> -patches to add the attribute would be very much appreciated.
>    

Sorry, I did not send this patch to qemu-devel for review.