From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=45146 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PhV0o-0008Ch-0Y for qemu-devel@nongnu.org; Mon, 24 Jan 2011 17:35:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PhUuG-0004yq-M6 for qemu-devel@nongnu.org; Mon, 24 Jan 2011 17:29:06 -0500 Received: from e32.co.us.ibm.com ([32.97.110.150]:48467) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PhUuG-0004yg-Gx for qemu-devel@nongnu.org; Mon, 24 Jan 2011 17:29:04 -0500 Received: from d03relay05.boulder.ibm.com (d03relay05.boulder.ibm.com [9.17.195.107]) by e32.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id p0OMIwg6004588 for ; Mon, 24 Jan 2011 15:18:58 -0700 Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by d03relay05.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p0OMT3nJ049010 for ; Mon, 24 Jan 2011 15:29:03 -0700 Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1]) by d03av03.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p0OMT2Xh004277 for ; Mon, 24 Jan 2011 15:29:03 -0700 Message-ID: <4D3DFD20.8060004@linux.vnet.ibm.com> Date: Mon, 24 Jan 2011 16:28:48 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1295902845-29807-1-git-send-email-aliguori@us.ibm.com> <1295902845-29807-3-git-send-email-aliguori@us.ibm.com> In-Reply-To: <1295902845-29807-3-git-send-email-aliguori@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Stefan Hajnoczi , Marcelo Tosatti , qemu-devel@nongnu.org, Paul Brook , Paulo Bonzini , Arun Bharadwaj On 01/24/2011 03:00 PM, Anthony Liguori wrote: > Leave the disable options for now to help with testing but these will be removed > once we're confident in the thread implementations. > > Disabled code bit rots. These have been in tree long enough that we need to > either commit to making them work or just remove them entirely. > I/O thread disables icount apparently. I'm not really sure why. Marcelo, do you know the reason qemu_calculate_timeout returns a fixed value in the I/O thread regardless of icount? Regards, Anthony Liguori > Signed-off-by: Anthony Liguori > > diff --git a/configure b/configure > index d68f862..d5ac074 100755 > --- a/configure > +++ b/configure > @@ -124,7 +124,7 @@ vnc_tls="" > vnc_sasl="" > vnc_jpeg="" > vnc_png="" > -vnc_thread="no" > +vnc_thread="yes" > xen="" > linux_aio="" > attr="" > @@ -161,7 +161,7 @@ darwin_user="no" > bsd_user="no" > guest_base="" > uname_release="" > -io_thread="no" > +io_thread="yes" > mixemu="no" > kerneldir="" > aix="no" > @@ -699,6 +699,8 @@ for opt do > ;; > --enable-io-thread) io_thread="yes" > ;; > + --disable-io-thread) io_thread="no" > + ;; > --disable-blobs) blobs="no" > ;; > --kerneldir=*) kerneldir="$optarg" > @@ -901,6 +903,7 @@ echo " --enable-linux-aio enable Linux AIO support" > echo " --disable-attr disables attr and xattr support" > echo " --enable-attr enable attr and xattr support" > echo " --enable-io-thread enable IO thread" > +echo " --disable-io-thread disable IO thread" > echo " --disable-blobs disable installing provided firmware blobs" > echo " --kerneldir=PATH look for kernel includes in PATH" > echo " --enable-docs enable documentation build" >