From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=48269 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PhWj9-0004qw-1w for qemu-devel@nongnu.org; Mon, 24 Jan 2011 19:25:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PhWj5-0001N8-NW for qemu-devel@nongnu.org; Mon, 24 Jan 2011 19:25:40 -0500 Received: from e3.ny.us.ibm.com ([32.97.182.143]:35718) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PhWj5-0001N4-IZ for qemu-devel@nongnu.org; Mon, 24 Jan 2011 19:25:39 -0500 Received: from d01dlp01.pok.ibm.com (d01dlp01.pok.ibm.com [9.56.224.56]) by e3.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id p0P06PT4002368 for ; Mon, 24 Jan 2011 19:06:30 -0500 Received: from d01relay05.pok.ibm.com (d01relay05.pok.ibm.com [9.56.227.237]) by d01dlp01.pok.ibm.com (Postfix) with ESMTP id A8054728042 for ; Mon, 24 Jan 2011 19:25:36 -0500 (EST) Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by d01relay05.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p0P0Pae5163184 for ; Mon, 24 Jan 2011 19:25:36 -0500 Received: from d01av04.pok.ibm.com (loopback [127.0.0.1]) by d01av04.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p0P0PZcx005146 for ; Mon, 24 Jan 2011 19:25:36 -0500 Message-ID: <4D3E1870.7060703@linux.vnet.ibm.com> Date: Mon, 24 Jan 2011 18:25:20 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [RFC][PATCH v6 08/23] virtagent: add va.getfile RPC References: <1295270117-24760-1-git-send-email-mdroth@linux.vnet.ibm.com> <1295270117-24760-9-git-send-email-mdroth@linux.vnet.ibm.com> <4D39B716.1010400@redhat.com> <20110121172026.GK12589@redhat.com> <4D39CF2C.1000407@linux.vnet.ibm.com> <20110124220809.GA4254@amd.home.annexia.org> <20110124222019.GA4602@amd.home.annexia.org> <4D3DFC81.4010807@linux.vnet.ibm.com> <20110124224808.GF25174@amd.home.annexia.org> <4D3E0DD5.8070408@linux.vnet.ibm.com> <4D3E17C0.1080504@linux.vnet.ibm.com> In-Reply-To: <4D3E17C0.1080504@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: agl@linux.vnet.ibm.com, stefanha@linux.vnet.ibm.com, Jes Sorensen , marcel.mittelstaedt@de.ibm.com, qemu-devel@nongnu.org, "Richard W.M. Jones" , ryanh@us.ibm.com, markus_mueller@de.ibm.com, abeekhof@redhat.com On 01/24/2011 06:22 PM, Michael Roth wrote: > > Actually, copyfile is the proposed open/read/write/close interface. > getfile is the current interface, and it seems to be a contentious > one. I've discussed it quite a bit with Jes here and in the last > couple RFCs. I think the current course is that we'll end up ditching > viewfile/viewdmesg in favor of copyfile, and that we should do it now > rather than later. > > The upshot is that "viewfile " is basically equivalent to: > copyfile_open /dev/stdout -> fd_handle; > copyfile_read fd ; > copyfile_close fd_handle". I really just want getfile. I think designing a partial read API at this stage isn't a good idea. Wait until there's a concrete use case before adding an interface. Regards, Anthony Liguori