From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Stefan Weil <weil@mail.berlios.de>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: [PATCH v4 0/4] strtosz() cleanups
Date: Tue, 25 Jan 2011 10:18:19 +0100 [thread overview]
Message-ID: <4D3E955B.2070705@redhat.com> (raw)
In-Reply-To: <4D3DB6A2.3060903@mail.berlios.de>
On 01/24/11 18:28, Stefan Weil wrote:
> There was some discussion regarding this patch set.
> I agree with Markus that part of the first patch
> should be removed: don't change char to unsigned char.
The unsigned char should definitely go in, leaving it as a signed char
doesn't serve any purpose.
> It's not necessary, and the result is, that now unsigned chars
> are assigned to chars which might raise future compiler
> warnings.
We already do that cast by calling qemu_toupper() and qemu_isspace() so
that argument is void.
Jes
next prev parent reply other threads:[~2011-01-25 9:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-24 15:33 [Qemu-devel] [PATCH v4 0/4] strtosz() cleanups Jes.Sorensen
2011-01-24 15:33 ` [Qemu-devel] [PATCH 1/4] strtosz(): use unsigned char and switch to qemu_isspace() Jes.Sorensen
2011-01-24 16:10 ` Markus Armbruster
2011-01-24 16:11 ` Jes Sorensen
2011-01-24 16:40 ` Markus Armbruster
2011-01-24 15:33 ` [Qemu-devel] [PATCH 2/4] strtosz() use qemu_toupper() to simplify switch statement Jes.Sorensen
2011-01-24 15:33 ` [Qemu-devel] [PATCH 3/4] strtosz(): Fix name confusion in use of modf() Jes.Sorensen
2011-01-24 15:33 ` [Qemu-devel] [PATCH 4/4] strtosz(): Use suffix macros in switch() statement Jes.Sorensen
2011-01-24 16:08 ` Markus Armbruster
2011-01-24 16:10 ` Jes Sorensen
2011-01-24 16:39 ` Markus Armbruster
2011-01-24 16:41 ` Jes Sorensen
2011-01-24 17:47 ` Markus Armbruster
2011-01-25 9:19 ` Jes Sorensen
2011-01-25 10:17 ` Markus Armbruster
2011-01-25 11:54 ` Jes Sorensen
2011-01-24 15:45 ` [Qemu-devel] Re: [PATCH v4 0/4] strtosz() cleanups Kevin Wolf
2011-01-24 17:28 ` Stefan Weil
2011-01-25 9:18 ` Jes Sorensen [this message]
2011-01-25 10:14 ` Markus Armbruster
2011-01-25 11:52 ` Jes Sorensen
2011-01-25 13:19 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D3E955B.2070705@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=weil@mail.berlios.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).