From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=59629 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Phf42-0001lP-Nr for qemu-devel@nongnu.org; Tue, 25 Jan 2011 04:19:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Phf2f-0005tg-Vx for qemu-devel@nongnu.org; Tue, 25 Jan 2011 04:18:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:19237) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Phf2f-0005sn-Oy for qemu-devel@nongnu.org; Tue, 25 Jan 2011 04:18:25 -0500 Message-ID: <4D3E955B.2070705@redhat.com> Date: Tue, 25 Jan 2011 10:18:19 +0100 From: Jes Sorensen MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH v4 0/4] strtosz() cleanups References: <1295883211-18288-1-git-send-email-Jes.Sorensen@redhat.com> <4D3D9E8B.20000@redhat.com> <4D3DB6A2.3060903@mail.berlios.de> In-Reply-To: <4D3DB6A2.3060903@mail.berlios.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: Kevin Wolf , qemu-devel@nongnu.org On 01/24/11 18:28, Stefan Weil wrote: > There was some discussion regarding this patch set. > I agree with Markus that part of the first patch > should be removed: don't change char to unsigned char. The unsigned char should definitely go in, leaving it as a signed char doesn't serve any purpose. > It's not necessary, and the result is, that now unsigned chars > are assigned to chars which might raise future compiler > warnings. We already do that cast by calling qemu_toupper() and qemu_isspace() so that argument is void. Jes