Re: [Qemu-devel] [PATCH 4/4] strtosz(): Use suffix macros in switch() statement

[Jes Sorensen <Jes.Sorensen@redhat.com>]

On 01/24/11 18:47, Markus Armbruster wrote:
> Jes Sorensen <Jes.Sorensen@redhat.com> writes:
>>>>> qemu_toupper() - whats the problem?
>>> If a STRTOSZ_DEFSUFFIX_T? expands to a lower case character, its case
>>> will not match any input.
>>
>> Right, so one has to be careful when adding new suffix constants.
> 
> Calls for a comment right next to the definition of the
> STRTOSZ_DEFSUFFIX_T*.
> 
> I hate unstated restrictions that are hidden far away from the place
> where you can break them.

Well I am fine with a comment in the code.

>> However given that we already have all the likely to be used ones for
>> the near future, that isn't exactly a big issue.
>>
>> On the other hand forcing the use of the macros makes it less likely
>> that someone specifies an unsupported constant by hitting 'y' instead of
>> 't' or similar.
> 
> Takes a combination of butterfingers, cross-eyedness, and near-total
> incompetence at basic smoke-testing.

Not really, all it takes is someone writing a piece of code, not
thinking about it, therefore only testing things where a suffix is
specified as an argument and it gets missed.

Jes