From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=53934 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PhhRj-0003xv-Fn for qemu-devel@nongnu.org; Tue, 25 Jan 2011 06:52:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PhhRh-0001Xf-Uc for qemu-devel@nongnu.org; Tue, 25 Jan 2011 06:52:27 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56170) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PhhRh-0001XX-NU for qemu-devel@nongnu.org; Tue, 25 Jan 2011 06:52:25 -0500 Message-ID: <4D3EB974.2050201@redhat.com> Date: Tue, 25 Jan 2011 12:52:20 +0100 From: Jes Sorensen MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH v4 0/4] strtosz() cleanups References: <1295883211-18288-1-git-send-email-Jes.Sorensen@redhat.com> <4D3D9E8B.20000@redhat.com> <4D3DB6A2.3060903@mail.berlios.de> <4D3E955B.2070705@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Kevin Wolf , qemu-devel@nongnu.org On 01/25/11 11:14, Markus Armbruster wrote: > Jes Sorensen writes: > >> On 01/24/11 18:28, Stefan Weil wrote: >>> There was some discussion regarding this patch set. >>> I agree with Markus that part of the first patch >>> should be removed: don't change char to unsigned char. >> >> The unsigned char should definitely go in, leaving it as a signed char >> doesn't serve any purpose. > > Leaving something as is doesn't need justification. Changing it does. > The justification presented so far was "it is prettier to match the real > behavior of pure toupper()". Which I don't buy. But without commit > access, I'm not a buyer. Well that is just too bad. qemu_toupper() is a hack around the fact that people often forget to use the right type, it is not an excuse for using the wrong type in the code. Jes