* [Qemu-devel] [PATCH] target-arm: Fix Neon vsra instructions.
@ 2011-01-25 17:18 Christophe Lyon
2011-01-31 15:48 ` Christophe Lyon
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Christophe Lyon @ 2011-01-25 17:18 UTC (permalink / raw)
To: qemu-devel@nongnu.org
This patch fixes the errors reported by my tests in VSRA.
Signed-off-by: Christophe Lyon <christophe.lyon@st.com>
---
target-arm/translate.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/target-arm/translate.c b/target-arm/translate.c
index 7cb48c0..4cf2ecd 100644
--- a/target-arm/translate.c
+++ b/target-arm/translate.c
@@ -4697,7 +4697,7 @@ static int disas_neon_data_insn(CPUState * env, DisasContext *s, uint32_t insn)
}
if (op == 1 || op == 3) {
/* Accumulate. */
- neon_load_reg64(cpu_V0, rd + pass);
+ neon_load_reg64(cpu_V1, rd + pass);
tcg_gen_add_i64(cpu_V0, cpu_V0, cpu_V1);
} else if (op == 4 || (op == 5 && u)) {
/* Insert */
@@ -4761,7 +4761,7 @@ static int disas_neon_data_insn(CPUState * env, DisasContext *s, uint32_t insn)
if (op == 1 || op == 3) {
/* Accumulate. */
tmp2 = neon_load_reg(rd, pass);
- gen_neon_add(size, tmp2, tmp);
+ gen_neon_add(size, tmp, tmp2);
dead_tmp(tmp2);
} else if (op == 4 || (op == 5 && u)) {
/* Insert */
--
1.7.2.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] target-arm: Fix Neon vsra instructions.
2011-01-25 17:18 [Qemu-devel] [PATCH] target-arm: Fix Neon vsra instructions Christophe Lyon
@ 2011-01-31 15:48 ` Christophe Lyon
2011-02-04 11:44 ` Peter Maydell
2011-02-04 19:49 ` Aurelien Jarno
2 siblings, 0 replies; 4+ messages in thread
From: Christophe Lyon @ 2011-01-31 15:48 UTC (permalink / raw)
To: qemu-devel@nongnu.org
On 25.01.2011 18:18, Christophe Lyon wrote:
> This patch fixes the errors reported by my tests in VSRA.
>
ping?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] target-arm: Fix Neon vsra instructions.
2011-01-25 17:18 [Qemu-devel] [PATCH] target-arm: Fix Neon vsra instructions Christophe Lyon
2011-01-31 15:48 ` Christophe Lyon
@ 2011-02-04 11:44 ` Peter Maydell
2011-02-04 19:49 ` Aurelien Jarno
2 siblings, 0 replies; 4+ messages in thread
From: Peter Maydell @ 2011-02-04 11:44 UTC (permalink / raw)
To: Christophe Lyon; +Cc: qemu-devel@nongnu.org
On 25 January 2011 17:18, Christophe Lyon <christophe.lyon@st.com> wrote:
> This patch fixes the errors reported by my tests in VSRA.
>
> Signed-off-by: Christophe Lyon <christophe.lyon@st.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] target-arm: Fix Neon vsra instructions.
2011-01-25 17:18 [Qemu-devel] [PATCH] target-arm: Fix Neon vsra instructions Christophe Lyon
2011-01-31 15:48 ` Christophe Lyon
2011-02-04 11:44 ` Peter Maydell
@ 2011-02-04 19:49 ` Aurelien Jarno
2 siblings, 0 replies; 4+ messages in thread
From: Aurelien Jarno @ 2011-02-04 19:49 UTC (permalink / raw)
To: Christophe Lyon; +Cc: qemu-devel@nongnu.org
On Tue, Jan 25, 2011 at 06:18:08PM +0100, Christophe Lyon wrote:
> This patch fixes the errors reported by my tests in VSRA.
>
> Signed-off-by: Christophe Lyon <christophe.lyon@st.com>
> ---
> target-arm/translate.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
Thanks applied.
> diff --git a/target-arm/translate.c b/target-arm/translate.c
> index 7cb48c0..4cf2ecd 100644
> --- a/target-arm/translate.c
> +++ b/target-arm/translate.c
> @@ -4697,7 +4697,7 @@ static int disas_neon_data_insn(CPUState * env, DisasContext *s, uint32_t insn)
> }
> if (op == 1 || op == 3) {
> /* Accumulate. */
> - neon_load_reg64(cpu_V0, rd + pass);
> + neon_load_reg64(cpu_V1, rd + pass);
> tcg_gen_add_i64(cpu_V0, cpu_V0, cpu_V1);
> } else if (op == 4 || (op == 5 && u)) {
> /* Insert */
> @@ -4761,7 +4761,7 @@ static int disas_neon_data_insn(CPUState * env, DisasContext *s, uint32_t insn)
> if (op == 1 || op == 3) {
> /* Accumulate. */
> tmp2 = neon_load_reg(rd, pass);
> - gen_neon_add(size, tmp2, tmp);
> + gen_neon_add(size, tmp, tmp2);
> dead_tmp(tmp2);
> } else if (op == 4 || (op == 5 && u)) {
> /* Insert */
> --
> 1.7.2.3
>
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-02-04 19:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-25 17:18 [Qemu-devel] [PATCH] target-arm: Fix Neon vsra instructions Christophe Lyon
2011-01-31 15:48 ` Christophe Lyon
2011-02-04 11:44 ` Peter Maydell
2011-02-04 19:49 ` Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).