From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=38093 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PiEPO-00027d-VO for qemu-devel@nongnu.org; Wed, 26 Jan 2011 18:04:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PiEPL-0001JH-IP for qemu-devel@nongnu.org; Wed, 26 Jan 2011 18:04:12 -0500 Received: from mail-qw0-f45.google.com ([209.85.216.45]:38454) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PiEPL-0001J2-Fz for qemu-devel@nongnu.org; Wed, 26 Jan 2011 18:04:11 -0500 Received: by qwk4 with SMTP id 4so1495191qwk.4 for ; Wed, 26 Jan 2011 15:04:11 -0800 (PST) Message-ID: <4D40A864.6040603@codemonkey.ws> Date: Wed, 26 Jan 2011 17:04:04 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH V9 09/16] xen: add a 8259 Interrupt Controller References: <1295965760-31508-1-git-send-email-anthony.perard@citrix.com> <1295965760-31508-10-git-send-email-anthony.perard@citrix.com> In-Reply-To: <1295965760-31508-10-git-send-email-anthony.perard@citrix.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: anthony.perard@citrix.com Cc: Xen Devel , QEMU-devel , Stefano Stabellini On 01/25/2011 08:29 AM, anthony.perard@citrix.com wrote: > From: Anthony PERARD > > Introduce a 8259 Interrupt Controller for target-xen; every set_irq > call makes a Xen hypercall. > > Signed-off-by: Anthony PERARD > Signed-off-by: Stefano Stabellini > --- > hw/xen_common.h | 2 ++ > hw/xen_machine_fv.c | 5 ++--- > xen-all.c | 12 ++++++++++++ > 3 files changed, 16 insertions(+), 3 deletions(-) > > diff --git a/hw/xen_common.h b/hw/xen_common.h > index b98d107..0cc935a 100644 > --- a/hw/xen_common.h > +++ b/hw/xen_common.h > @@ -42,4 +42,6 @@ static inline int xc_fd(xc_interface *xen_xc) > } > #endif > > +qemu_irq *i8259_xen_init(void); > + > #endif /* QEMU_HW_XEN_COMMON_H */ > diff --git a/hw/xen_machine_fv.c b/hw/xen_machine_fv.c > index 2f51625..0a90312 100644 > --- a/hw/xen_machine_fv.c > +++ b/hw/xen_machine_fv.c > @@ -37,6 +37,7 @@ > #include "xen_common.h" > #include "xen/hvm/hvm_info_table.h" > #include "xen_platform.h" > +#include "xen_common.h" > > #define MAX_IDE_BUS 2 > > @@ -52,7 +53,6 @@ static void xen_init_fv(ram_addr_t ram_size, > PCIBus *pci_bus; > PCII440FXState *i440fx_state; > int piix3_devfn = -1; > - qemu_irq *cpu_irq; > qemu_irq *isa_irq; > qemu_irq *i8259; > qemu_irq *cmos_s3; > @@ -76,8 +76,7 @@ static void xen_init_fv(ram_addr_t ram_size, > env = cpu_init(cpu_model); > env->halted = 1; > > - cpu_irq = pc_allocate_cpu_irq(); > - i8259 = i8259_init(cpu_irq[0]); > + i8259 = i8259_xen_init(); > isa_irq_state = qemu_mallocz(sizeof (*isa_irq_state)); > isa_irq_state->i8259 = i8259; > > diff --git a/xen-all.c b/xen-all.c > index 8a51873..205cbc4 100644 > --- a/xen-all.c > +++ b/xen-all.c > @@ -43,6 +43,18 @@ void xen_piix_pci_write_config_client(uint32_t address, uint32_t val, int len) > } > } > > +/* i8259 */ > + > +static void i8259_set_irq(void *opaque, int irq, int level) > +{ > + xc_hvm_set_isa_irq_level(xen_xc, xen_domid, irq, level); > +} > + > +qemu_irq *i8259_xen_init(void) > +{ > + return qemu_allocate_irqs(i8259_set_irq, NULL, 16); > +} > + > I think it would make more sense to just call it a Xen interrupt controller as it's clearly not an i8259. Xen may emulate an i8259 in the kernel but this has nothing to do with that AFAIK. Regards, Anthony Liguori > /* Initialise Xen */ > > int xen_init(int smp_cpus) >