qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <bonzini@gnu.org>
To: qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Fwd: Proposal: Improving patch tracking and review using Rietveld
Date: Thu, 27 Jan 2011 08:55:30 +0100	[thread overview]
Message-ID: <4D4124F2.7060407@gnu.org> (raw)

Forwarding this from the GCC mailing list.  Since patchwork isn't more 
than a mail archive the way it's implemented in QEMU, this may be a more 
interesting possibility.

Paolo

> At Google we use a code review tool which was open sourced a couple of
> years ago: Rietveld
> (http://code.google.com/appengine/articles/rietveld.html).
>
> The best way of thinking about it is "bugzilla for patches".  The
> system creates an entry for every patch submitted, provides a web tool
> for manipulating the patch (comments, different views of the diff,
> highlighting, etc) and it also has an email gateway.
>
> We have discussed patch tracking mechanisms in the past, and none so
> far has taken hold.  The reason why I like Rietveld is that it doesn't
> really matter whether we all switch to using it at once:
>
> 1- Rietveld always send the patch sent to it to gcc-patches@ (provided
> the submitter added gcc-patches to the CC list).
> 2- The whole trail of discussion on the patch also get sent to
> gcc-patches and everyone else is CC'd in it.
> 3- Reviewers do not need to use the web tool to reply to the patch.
> One can simply respond to the e-mail, and it will get added to the
> patch discussion trail.
>
> So, for people who do not want to use the tool, Rietveld will not get
> in the way.  They can simply respond to the patch as usual, and as
> long as they keep the rietveld email address in the CC list, the patch
> trail will be updated automatically.
>
> At Google we will start using Rietveld to send patches.  The only
> difference folks will notice is that Rietveld-generated email has some
> extra text.
>
> I have created a wiki page that explains the basics of using Rietveld
> (thanks Jeffrey for the instructions):
> http://gcc.gnu.org/wiki/rietveld
>
> Once again, I'd like to underscore the fact that if a patch submitter
> chooses to use Rietveld for tracking their patches, this should not
> affect in any way the traditional mail-based review.  All I ask is
> that reviewers maintain the CC and Subject line intact in order to not
> confuse the tool.
>
> Jeffrey, would you mind looking over the instructions I've written to
> make sure they're correct?
>
> Richard, this is the tool I mentioned in today's chat.
>
>
> Thanks.  Diego.

             reply	other threads:[~2011-01-27  7:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-27  7:55 Paolo Bonzini [this message]
2011-01-27 10:19 ` [Qemu-devel] Fwd: Proposal: Improving patch tracking and review using Rietveld Stefan Hajnoczi
2011-01-27 10:23   ` Paolo Bonzini
2011-01-27 10:34     ` Stefan Hajnoczi
2011-01-27 16:26     ` [Qemu-devel] " Paolo Bonzini
2011-01-27 16:31       ` Diego Novillo
2011-01-27 17:31 ` [Qemu-devel] " Anthony Liguori
2011-01-27 18:32   ` Peter Maydell
2011-01-27 19:40   ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D4124F2.7060407@gnu.org \
    --to=bonzini@gnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).