From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=54368 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PiN3D-0002UR-VX
	for qemu-devel@nongnu.org; Thu, 27 Jan 2011 03:17:56 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1PiN3C-0004CY-Nt
	for qemu-devel@nongnu.org; Thu, 27 Jan 2011 03:17:55 -0500
Received: from mx1.redhat.com ([209.132.183.28]:17981)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1PiN3C-0004CC-H7
	for qemu-devel@nongnu.org; Thu, 27 Jan 2011 03:17:54 -0500
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id p0R8Hqq3008533
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 27 Jan 2011 03:17:53 -0500
Message-ID: <4D412A2D.8050605@redhat.com>
Date: Thu, 27 Jan 2011 09:17:49 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] hw/qxl: another missing unlock
References: <1295966534-13121-1-git-send-email-alevy@redhat.com>
In-Reply-To: <1295966534-13121-1-git-send-email-alevy@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alon Levy <alevy@redhat.com>
Cc: qemu-devel@nongnu.org

On 01/25/11 15:42, Alon Levy wrote:
> We need to unlock the mutex before waiting on read via
> the worker call since the worker will try to lock and hang
> otherwise.
>
> Signed-off-by: Alon Levy<alevy@redhat.com>
> ---
>   hw/qxl.c |    2 ++
>   1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/hw/qxl.c b/hw/qxl.c
> index 117f7c8..00c31c7 100644
> --- a/hw/qxl.c
> +++ b/hw/qxl.c
> @@ -791,7 +791,9 @@ static void qxl_add_memslot(PCIQXLDevice *d, uint32_t slot_id, uint64_t delta)
>              __FUNCTION__, memslot.slot_id,
>              memslot.virt_start, memslot.virt_end);
>
> +    qxl_unlock_iothread(&d->ssd);
>       d->ssd.worker->add_memslot(d->ssd.worker,&memslot);
> +    qxl_lock_iothread(&d->ssd);
>       d->guest_slots[slot_id].ptr = (void*)memslot.virt_start;
>       d->guest_slots[slot_id].size = memslot.virt_end - memslot.virt_start;
>       d->guest_slots[slot_id].delta = delta;

added to spice patch queue

thanks,
   Gerd