From: Paolo Bonzini <bonzini@gnu.org>
To: Diego Novillo <dnovillo@google.com>
Cc: gcc@gnu.org, Jeffrey Yasskin <jyasskin@google.com>,
Richard Earnshaw <rearnsha@arm.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Re: Proposal: Improving patch tracking and review using Rietveld
Date: Thu, 27 Jan 2011 11:25:39 +0100 [thread overview]
Message-ID: <4D414823.2060005@gnu.org> (raw)
In-Reply-To: <AANLkTimkJA8OGjrhwsrzbm6W+NZXKeUnG7EYEHVZ+xen@mail.gmail.com>
On 01/26/2011 08:56 PM, Diego Novillo wrote:
> At Google we use a code review tool which was open sourced a couple of
> years ago: Rietveld
> (http://code.google.com/appengine/articles/rietveld.html).
>
> The best way of thinking about it is "bugzilla for patches". The
> system creates an entry for every patch submitted, provides a web tool
> for manipulating the patch (comments, different views of the diff,
> highlighting, etc) and it also has an email gateway.
>
> We have discussed patch tracking mechanisms in the past, and none so
> far has taken hold. The reason why I like Rietveld is that it doesn't
> really matter whether we all switch to using it at once:
>
> 1- Rietveld always send the patch sent to it to gcc-patches@ (provided
> the submitter added gcc-patches to the CC list).
> 2- The whole trail of discussion on the patch also get sent to
> gcc-patches and everyone else is CC'd in it.
> 3- Reviewers do not need to use the web tool to reply to the patch.
> One can simply respond to the e-mail, and it will get added to the
> patch discussion trail.
How does this work WRT multiple revisions of the same patch?
I am taking the liberty of CCing qemu-devel since I forwarded your
message there.
Paolo
parent reply other threads:[~2011-01-27 10:25 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <AANLkTimkJA8OGjrhwsrzbm6W+NZXKeUnG7EYEHVZ+xen@mail.gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D414823.2060005@gnu.org \
--to=bonzini@gnu.org \
--cc=dnovillo@google.com \
--cc=gcc@gnu.org \
--cc=jyasskin@google.com \
--cc=qemu-devel@nongnu.org \
--cc=rearnsha@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).