From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=51908 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PiP2y-0004JB-Mq
	for qemu-devel@nongnu.org; Thu, 27 Jan 2011 05:25:49 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1PiP2v-0000t1-Pr
	for qemu-devel@nongnu.org; Thu, 27 Jan 2011 05:25:48 -0500
Received: from mail-pv0-f173.google.com ([74.125.83.173]:62310)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1PiP2v-0000sc-JS
	for qemu-devel@nongnu.org; Thu, 27 Jan 2011 05:25:45 -0500
Received: by pvh11 with SMTP id 11so263822pvh.4
	for <qemu-devel@nongnu.org>; Thu, 27 Jan 2011 02:25:44 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4D414823.2060005@gnu.org>
Date: Thu, 27 Jan 2011 11:25:39 +0100
From: Paolo Bonzini <bonzini@gnu.org>
MIME-Version: 1.0
References: <AANLkTimkJA8OGjrhwsrzbm6W+NZXKeUnG7EYEHVZ+xen@mail.gmail.com>
In-Reply-To: <AANLkTimkJA8OGjrhwsrzbm6W+NZXKeUnG7EYEHVZ+xen@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: Proposal: Improving patch tracking and review
	using Rietveld
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Diego Novillo <dnovillo@google.com>
Cc: gcc@gnu.org, Jeffrey Yasskin <jyasskin@google.com>, Richard Earnshaw <rearnsha@arm.com>, qemu-devel <qemu-devel@nongnu.org>

On 01/26/2011 08:56 PM, Diego Novillo wrote:
> At Google we use a code review tool which was open sourced a couple of
> years ago: Rietveld
> (http://code.google.com/appengine/articles/rietveld.html).
>
> The best way of thinking about it is "bugzilla for patches".  The
> system creates an entry for every patch submitted, provides a web tool
> for manipulating the patch (comments, different views of the diff,
> highlighting, etc) and it also has an email gateway.
>
> We have discussed patch tracking mechanisms in the past, and none so
> far has taken hold.  The reason why I like Rietveld is that it doesn't
> really matter whether we all switch to using it at once:
>
> 1- Rietveld always send the patch sent to it to gcc-patches@ (provided
> the submitter added gcc-patches to the CC list).
> 2- The whole trail of discussion on the patch also get sent to
> gcc-patches and everyone else is CC'd in it.
> 3- Reviewers do not need to use the web tool to reply to the patch.
> One can simply respond to the e-mail, and it will get added to the
> patch discussion trail.

How does this work WRT multiple revisions of the same patch?

I am taking the liberty of CCing qemu-devel since I forwarded your 
message there.

Paolo