From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Chunqiang Tang <ctang@us.ibm.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/5] Fast Virtual Disk (FVD) Proposal Part 1
Date: Thu, 27 Jan 2011 13:23:16 +0100 [thread overview]
Message-ID: <4D4163B4.8070304@redhat.com> (raw)
In-Reply-To: <OFCC0F580C.44672C18-ON85257822.005055EB-85257822.00516340@us.ibm.com>
On 01/24/11 15:50, Chunqiang Tang wrote:
>> I think the root of the problem is that your series didn't maintain
>> bisectability.
>>
>> IOW, each patch needs to be able to be applied one at a time such that
>> at each point, the build doesn't break and functionality doesn't break.
>>
>> Otherwise, tools like git bisect don't work.
>
> This was true with the old, big FVD patches you reviewed. Following
> Christoph Hellwig's suggestion, the new series of FVD patches submitted
> last Friday, e.g., "FVD: Added the simulated 'blksim' driver", add
> individual smaller functions and breaks neither compilation nor execution.
Then you need to break up the new patch into smaller chunks and make
sure they can each be applied without breaking the build.
Having a separate patch that moves functions to another file, because
they are too be shared, is a completely valid patch.
Jes
prev parent reply other threads:[~2011-01-27 12:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-19 22:04 [Qemu-devel] [PATCH 1/5] Fast Virtual Disk (FVD) Proposal Part 1 Chunqiang Tang
2011-01-19 22:04 ` [Qemu-devel] [PATCH 2/5] Fast Virtual Disk (FVD) Proposal Part 2 Chunqiang Tang
2011-01-19 22:04 ` [Qemu-devel] [PATCH 3/5] Fast Virtual Disk (FVD) Proposal Part 3 Chunqiang Tang
2011-01-21 22:57 ` Anthony Liguori
2011-01-21 23:09 ` Anthony Liguori
2011-01-24 15:29 ` Chunqiang Tang
2011-01-19 22:04 ` [Qemu-devel] [PATCH 4/5] Fast Virtual Disk (FVD) Proposal Part 4 Chunqiang Tang
2011-01-19 22:04 ` [Qemu-devel] [PATCH 5/5] Fast Virtual Disk (FVD) Proposal Part 5 Chunqiang Tang
2011-01-20 13:01 ` [Qemu-devel] [PATCH 1/5] Fast Virtual Disk (FVD) Proposal Part 1 Christoph Hellwig
2011-01-20 14:49 ` Chunqiang Tang
2011-01-20 17:08 ` Stefan Weil
2011-01-22 9:02 ` Peter Maydell
2011-01-24 14:56 ` Chunqiang Tang
2011-01-21 22:41 ` Anthony Liguori
2011-01-22 2:51 ` Chunqiang Tang
2011-01-23 23:27 ` Anthony Liguori
2011-01-24 14:50 ` Chunqiang Tang
2011-01-27 12:23 ` Jes Sorensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D4163B4.8070304@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=ctang@us.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).