From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=53179 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Piicz-0008IX-AO
	for qemu-devel@nongnu.org; Fri, 28 Jan 2011 02:20:18 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hare@suse.de>) id 1Piicy-00066G-3y
	for qemu-devel@nongnu.org; Fri, 28 Jan 2011 02:20:17 -0500
Received: from cantor.suse.de ([195.135.220.2]:60319 helo=mx1.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <hare@suse.de>)
	id 1Piicx-00065x-UF
	for qemu-devel@nongnu.org; Fri, 28 Jan 2011 02:20:16 -0500
Message-ID: <4D426FEC.2080405@suse.de>
Date: Fri, 28 Jan 2011 08:27:40 +0100
From: Hannes Reinecke <hare@suse.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: Commit 622b520f changed -drive if=scsi, index=N,
	intentional?
References: <m3oc72eed1.fsf@blackfin.pond.sub.org>
	<4D416342.6080001@redhat.com> <4D41C6CA.2000404@redhat.com>
In-Reply-To: <4D41C6CA.2000404@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>, Christoph Hellwig <hch@lst.de>

On 01/27/2011 08:26 PM, Gerd Hoffmann wrote:
>   Hi,
>=20
>>           } else if (!strcmp(buf, "scsi")) {
>>              type =3D IF_SCSI;
>> -            max_devs =3D MAX_SCSI_DEVS;
>> +            max_devs =3D 7;
>=20
>> That's very obviously not much more than a hack, but I don't think
>> blockdev.c can get the real number easily (please prove me wrong). Wit=
h
>> this hack, we would get the old behaviour for -drive (which doesn't us=
e
>> any other controller anyway) and you can still use -device to attach
>> more devices to a non-lsi bus.
>=20
> Looks sensible to me.  scsi controllers with more than 7 devs (megasas
> and whatever else might be coming, virtio?) can't be added via if=3Dscs=
i
> legacy syntax and must use -blockdev and -device anyway.
>=20
> We probably want add a comment explaining this though.
>=20
Yes please. It's a bit non-obvious that 'scsi' means in fact 'lsi'.

As long as there a way of specifying more than 8 devs
I'm fine with that patch.

Cheers,

Hannes
--=20
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg
GF: Markus Rex, HRB 16746 (AG N=FCrnberg)