From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=50507 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PijOg-0002PP-76
	for qemu-devel@nongnu.org; Fri, 28 Jan 2011 03:09:36 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1PijOB-00048m-0H
	for qemu-devel@nongnu.org; Fri, 28 Jan 2011 03:09:04 -0500
Received: from mail-wy0-f173.google.com ([74.125.82.173]:54570)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1PijOA-00048g-Pv
	for qemu-devel@nongnu.org; Fri, 28 Jan 2011 03:09:02 -0500
Received: by wyg36 with SMTP id 36so3028914wyg.4
	for <qemu-devel@nongnu.org>; Fri, 28 Jan 2011 00:09:02 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4D427998.4000708@redhat.com>
Date: Fri, 28 Jan 2011 09:08:56 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <cover.1296133797.git.jan.kiszka@siemens.com>
	<62151287710d788ebae642df9c4451bafaf8fd23.1296133797.git.jan.kiszka@siemens.com>
In-Reply-To: <62151287710d788ebae642df9c4451bafaf8fd23.1296133797.git.jan.kiszka@siemens.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 10/22] kvm: Set up signal mask also for
	!CONFIG_IOTHREAD
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, Avi Kivity <avi@redhat.com>, kvm@vger.kernel.org, qemu-devel@nongnu.org

On 01/27/2011 02:09 PM, Jan Kiszka wrote:
> Block SIG_IPI, unblock it during KVM_RUN, just like in io-thread mode.
> It's unused so far, but this infrastructure will be required for
> self-IPIs and to process SIGBUS plus, in KVM mode, SIGIO and SIGALRM. As
> Windows doesn't support signal services, we need to provide a stub for
> the init function.
>
> Signed-off-by: Jan Kiszka<jan.kiszka@siemens.com>
> ---
>   cpus.c |   13 +++++++++++--
>   1 files changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/cpus.c b/cpus.c
> index 16bd8fa..03c89b4 100644
> --- a/cpus.c
> +++ b/cpus.c
> @@ -231,7 +231,6 @@ fail:
>       return err;
>   }
>
> -#ifdef CONFIG_IOTHREAD
>   static void dummy_signal(int sig)
>   {
>   }
> @@ -246,6 +245,12 @@ static void qemu_kvm_init_cpu_signals(CPUState *env)
>       sigact.sa_handler = dummy_signal;
>       sigaction(SIG_IPI,&sigact, NULL);
>
> +#ifndef CONFIG_IOTHREAD
> +    sigemptyset(&set);
> +    sigaddset(&set, SIG_IPI);
> +    pthread_sigmask(SIG_BLOCK,&set, NULL);
> +#endif
> +
>       pthread_sigmask(SIG_BLOCK, NULL,&set);
>       sigdelset(&set, SIG_IPI);
>       sigdelset(&set, SIGBUS);
> @@ -255,7 +260,6 @@ static void qemu_kvm_init_cpu_signals(CPUState *env)
>           exit(1);
>       }
>   }
> -#endif
>
>   #else /* _WIN32 */
>
> @@ -284,6 +288,10 @@ static void qemu_event_increment(void)
>           exit (1);
>       }
>   }
> +
> +static void qemu_kvm_init_cpu_signals(CPUState *env)
> +{
> +}
>   #endif /* _WIN32 */
>
>   #ifndef CONFIG_IOTHREAD
> @@ -312,6 +320,7 @@ void qemu_init_vcpu(void *_env)
>               fprintf(stderr, "kvm_init_vcpu failed: %s\n", strerror(-r));
>               exit(1);
>           }
> +        qemu_kvm_init_cpu_signals(env);
>       }
>   }
>

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>