qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Jiri Denemark <jdenemar@redhat.com>, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 7/8] configure: Fix spice probe
Date: Fri, 28 Jan 2011 14:37:02 +0100	[thread overview]
Message-ID: <4D42C67E.6020602@redhat.com> (raw)
In-Reply-To: <1295886049-30548-8-git-send-email-kraxel@redhat.com>

On 01/24/2011 05:20 PM, Gerd Hoffmann wrote:
> From: Jiri Denemark<Jiri.Denemark@gmail.com>
>
> Non-existent $pkgconfig instead of $pkg_config was used when configure
> probes for spice availability.
>
> Signed-off-by: Jiri Denemark<jdenemar@redhat.com>
> Signed-off-by: Gerd Hoffmann<kraxel@redhat.com>
> ---
>   configure |    6 +++---
>   1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/configure b/configure
> index 210670c..dc469b2 100755
> --- a/configure
> +++ b/configure
> @@ -2207,9 +2207,9 @@ if test "$spice" != "no" ; then
>   #include<spice.h>
>   int main(void) { spice_server_new(); return 0; }
>   EOF
> -  spice_cflags=$($pkgconfig --cflags spice-protocol spice-server 2>/dev/null)
> -  spice_libs=$($pkgconfig --libs spice-protocol spice-server 2>/dev/null)
> -  if $pkgconfig --atleast-version=0.5.3 spice-server>/dev/null 2>&1&&  \
> +  spice_cflags=$($pkg_config --cflags spice-protocol spice-server 2>/dev/null)
> +  spice_libs=$($pkg_config --libs spice-protocol spice-server 2>/dev/null)
> +  if $pkg_config --atleast-version=0.5.3 spice-server>/dev/null 2>&1&&  \
>        compile_prog "$spice_cflags" "$spice_libs" ; then
>       spice="yes"
>       libs_softmmu="$libs_softmmu $spice_libs"

Don't know about the rest of the series, but this one is definitely 0.14 
material as SPICE doesn't work otherwise.

Paolo

  reply	other threads:[~2011-01-28 13:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-24 16:20 [Qemu-devel] [PULL 0/8] spice patch queue Gerd Hoffmann
2011-01-24 16:20 ` [Qemu-devel] [PATCH 1/8] add migration state change notifiers Gerd Hoffmann
2011-01-24 16:20 ` [Qemu-devel] [PATCH 2/8] spice/vnc: client migration Gerd Hoffmann
2011-01-24 16:20 ` [Qemu-devel] [PATCH 3/8] spice: MAINTAINERS update Gerd Hoffmann
2011-01-24 16:20 ` [Qemu-devel] [PATCH 4/8] vnc/spice: fix "never" and "now" expire_time Gerd Hoffmann
2011-01-24 16:20 ` [Qemu-devel] [PATCH 5/8] spice/qxl: zap spice 0.4 migration compatibility bits Gerd Hoffmann
2011-01-24 16:20 ` [Qemu-devel] [PATCH 6/8] qxl: locking fix Gerd Hoffmann
2011-01-24 16:20 ` [Qemu-devel] [PATCH 7/8] configure: Fix spice probe Gerd Hoffmann
2011-01-28 13:37   ` Paolo Bonzini [this message]
2011-01-24 16:20 ` [Qemu-devel] [PATCH 8/8] spice: add chardev (v5) Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D42C67E.6020602@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=jdenemar@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).