From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=40777 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PioVf-0007k3-GN
	for qemu-devel@nongnu.org; Fri, 28 Jan 2011 08:37:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1PioVe-0000YE-Ei
	for qemu-devel@nongnu.org; Fri, 28 Jan 2011 08:37:07 -0500
Received: from mail-gw0-f45.google.com ([74.125.83.45]:55745)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1PioVe-0000YA-Aq
	for qemu-devel@nongnu.org; Fri, 28 Jan 2011 08:37:06 -0500
Received: by gwaa12 with SMTP id a12so1188001gwa.4
	for <qemu-devel@nongnu.org>; Fri, 28 Jan 2011 05:37:05 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4D42C67E.6020602@redhat.com>
Date: Fri, 28 Jan 2011 14:37:02 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1295886049-30548-1-git-send-email-kraxel@redhat.com>
	<1295886049-30548-8-git-send-email-kraxel@redhat.com>
In-Reply-To: <1295886049-30548-8-git-send-email-kraxel@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 7/8] configure: Fix spice probe
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Jiri Denemark <jdenemar@redhat.com>, qemu-devel@nongnu.org

On 01/24/2011 05:20 PM, Gerd Hoffmann wrote:
> From: Jiri Denemark<Jiri.Denemark@gmail.com>
>
> Non-existent $pkgconfig instead of $pkg_config was used when configure
> probes for spice availability.
>
> Signed-off-by: Jiri Denemark<jdenemar@redhat.com>
> Signed-off-by: Gerd Hoffmann<kraxel@redhat.com>
> ---
>   configure |    6 +++---
>   1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/configure b/configure
> index 210670c..dc469b2 100755
> --- a/configure
> +++ b/configure
> @@ -2207,9 +2207,9 @@ if test "$spice" != "no" ; then
>   #include<spice.h>
>   int main(void) { spice_server_new(); return 0; }
>   EOF
> -  spice_cflags=$($pkgconfig --cflags spice-protocol spice-server 2>/dev/null)
> -  spice_libs=$($pkgconfig --libs spice-protocol spice-server 2>/dev/null)
> -  if $pkgconfig --atleast-version=0.5.3 spice-server>/dev/null 2>&1&&  \
> +  spice_cflags=$($pkg_config --cflags spice-protocol spice-server 2>/dev/null)
> +  spice_libs=$($pkg_config --libs spice-protocol spice-server 2>/dev/null)
> +  if $pkg_config --atleast-version=0.5.3 spice-server>/dev/null 2>&1&&  \
>        compile_prog "$spice_cflags" "$spice_libs" ; then
>       spice="yes"
>       libs_softmmu="$libs_softmmu $spice_libs"

Don't know about the rest of the series, but this one is definitely 0.14 
material as SPICE doesn't work otherwise.

Paolo