[Qemu-devel] Re: [PATCH 04/22] Leave inner main_loop faster on pending requests

[Avi Kivity <avi@redhat.com>]

On 01/27/2011 03:09 PM, Jan Kiszka wrote:
> If there is any pending request that requires us to leave the inner loop
> if main_loop, makes sure we do this as soon as possible by enforcing
> non-blocking IO processing.
>
> At this change, move variable definitions out of the inner loop to
> improve readability.
>
> Signed-off-by: Jan Kiszka<jan.kiszka@siemens.com>
> ---
>   vl.c |   11 +++++++----
>   1 files changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index 5fad700..2ebc55b 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -1384,18 +1384,21 @@ qemu_irq qemu_system_powerdown;
>
>   static void main_loop(void)
>   {
> +    bool nonblocking = false;
> +#ifdef CONFIG_PROFILER
> +    int64_t ti;
> +#endif
>       int r;
>
>       qemu_main_loop_start();
>
>       for (;;) {
>           do {
> -            bool nonblocking = false;
> -#ifdef CONFIG_PROFILER
> -            int64_t ti;
> -#endif
>   #ifndef CONFIG_IOTHREAD
>               nonblocking = cpu_exec_all();
> +            if (!vm_can_run()) {
> +                nonblocking = true;
> +            }

Doesn't this cause vmstop to spin?  We'll never execute 
main_loop_wait(false) if I read the code correctly?

-- 
error compiling committee.c: too many arguments to function