From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=59803 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PjrTQ-0001cs-AE for qemu-devel@nongnu.org; Mon, 31 Jan 2011 05:59:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PjrTL-0003Yu-Ku for qemu-devel@nongnu.org; Mon, 31 Jan 2011 05:59:06 -0500 Received: from mx1.redhat.com ([209.132.183.28]:30731) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PjrTL-0003YO-CR for qemu-devel@nongnu.org; Mon, 31 Jan 2011 05:59:03 -0500 Message-ID: <4D469658.5080806@redhat.com> Date: Mon, 31 Jan 2011 12:00:40 +0100 From: Kevin Wolf MIME-Version: 1.0 References: <1296210106-11145-1-git-send-email-armbru@redhat.com> In-Reply-To: <1296210106-11145-1-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH v2 00/11] -drive/drive_add fixes and cleanups List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: stefanha@gmail.com, qemu-devel@nongnu.org, hare@suse.de Am 28.01.2011 11:21, schrieb Markus Armbruster: > Kevin found a bug in my recent "[PATCH 3+5/5] -drive/drive_add fixes". > This is a rework of those two patches, plus a fix for the -drive > if=scsi,index=N regression, plus the odd bonus fix found on the way. > > v2: fix for the -drive if=scsi,index=N regression. PATCH 4 fixed up > slightly, PATCH 5 inserted, rest trivially rediffed. > > Markus Armbruster (11): > scsi hotplug: Set DriveInfo member bus correctly > blockdev: New drive_get_next(), replacing qdev_init_bdrv() > blockdev: Move BlockInterfaceType from qemu-common.h to blockdev.h > blockdev: Put BlockInterfaceType names and max_devs in tables > blockdev: Fix regression in -drive if=scsi,index=N > blockdev: Make drive_add() take explicit type, index parameters > blockdev: Replace drive_add()'s fmt, ... by optstr parameter > blockdev: Factor drive_index_to_{bus,unit}_id out of drive_init() > blockdev: New drive_get_by_index() > blockdev: Reject multiple definitions for the same drive > blockdev: Fix drive_add for drives without media > > blockdev.c | 143 +++++++++++++++++++++++++++++++-------------------- > blockdev.h | 18 +++++-- > hw/device-hotplug.c | 5 +- > hw/ide.h | 2 + > hw/ide/ahci.c | 1 - > hw/pci-hotplug.c | 1 + > hw/pl181.c | 7 ++- > hw/qdev.c | 15 ----- > hw/qdev.h | 2 - > hw/scsi.h | 3 +- > hw/ssi-sd.c | 7 ++- > hw/usb-msd.c | 3 +- > qemu-common.h | 6 -- > savevm.c | 1 - > vl.c | 94 +++++++++++++++++++-------------- > 15 files changed, 171 insertions(+), 137 deletions(-) Thanks, applied all to the block branch. Kevin