From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=48516 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pjuiu-0003z1-Hl for qemu-devel@nongnu.org; Mon, 31 Jan 2011 09:27:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pjuit-0001GZ-3J for qemu-devel@nongnu.org; Mon, 31 Jan 2011 09:27:20 -0500 Received: from eu1sys200aog112.obsmtp.com ([207.126.144.133]:41337) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pjuis-0001Fb-SI for qemu-devel@nongnu.org; Mon, 31 Jan 2011 09:27:19 -0500 Message-ID: <4D46C6BA.1010208@st.com> Date: Mon, 31 Jan 2011 15:27:06 +0100 From: Christophe Lyon MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 1/8] target-arm: Fixes for several shift instructions: VRSHL, VRSHR, VRSHRN, VSHLL, VRSRA. References: <1296229866-32011-1-git-send-email-christophe.lyon@st.com> <1296229866-32011-2-git-send-email-christophe.lyon@st.com> <20110131082050.GA4304@volta.aurel32.net> <4D468262.8020703@st.com> <20110131094414.GA7112@hall.aurel32.net> In-Reply-To: <20110131094414.GA7112@hall.aurel32.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno Cc: "qemu-devel@nongnu.org" On 31.01.2011 10:44, Aurelien Jarno wrote: > On Mon, Jan 31, 2011 at 10:35:30AM +0100, Christophe Lyon wrote: >> On 31.01.2011 09:20, Aurelien Jarno wrote: >>> On Fri, Jan 28, 2011 at 04:50:59PM +0100, christophe.lyon@st.com wrote: >>>> From: Christophe Lyon >>>> >>>> Handle corner cases where the addition of the rounding constant could >>>> cause overflows. >>> >>> After applying this patch, I get the following gcc warning: >>> CC translate.o >>> cc1: warnings being treated as errors >>> qemu/target-arm/translate.c: In function ‘disas_neon_data_insn’: >>> qemu/target-arm/translate.c:4212: error: ‘imm’ may be used uninitialized in this function >>> make: *** [translate.o] Error 1 >>> >> >> Which GCC version are you using? I don't have such a warning (using GCC-4.5.1 on x86_64). >> > > I get this error with GCC 4.3.5, GCC 4.4.5, GCC 4.5.2 and GCC 4.6.0 > (r169270). This is also on x86_64. > Well, I can't reproduce this error :-( For the record, I configure with --target-list=arm-softmmu,arm-linux-user --disable-bluez --enable-debug --disable-sdl and point --host-cc and --cc to GCC-4.5.1. In verbose mode, I confirm that GCC is invoked with -Werror -m64 -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wendif-labels -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fstack-protector-all -Wmissing-include-dirs -Wempty-body -Wnested-externs -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers -Wold-style-declaration -Wold-style-definition -Wtype-limits I have tried from a freshly cloned qemu.git, and I have no error. Can you send me your translate.c & translate.i (pre-processed by GCC's C-preprocesssor with -E option) Christophe.