From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=37764 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Pke5x-0002Yb-6s
	for qemu-devel@nongnu.org; Wed, 02 Feb 2011 09:54:13 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1PkXiS-00085x-12
	for qemu-devel@nongnu.org; Wed, 02 Feb 2011 03:05:28 -0500
Received: from mail-wy0-f173.google.com ([74.125.82.173]:49925)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1PkXiR-00085t-T5
	for qemu-devel@nongnu.org; Wed, 02 Feb 2011 03:05:27 -0500
Received: by wyg36 with SMTP id 36so7809659wyg.4
	for <qemu-devel@nongnu.org>; Wed, 02 Feb 2011 00:05:27 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4D491044.5090709@redhat.com>
Date: Wed, 02 Feb 2011 09:05:24 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1296199312-26334-1-git-send-email-tamura.yoshiaki@lab.ntt.co.jp>	<1296199312-26334-16-git-send-email-tamura.yoshiaki@lab.ntt.co.jp>	<4D42C41D.7090705@redhat.com>	<AANLkTinaSgv-g+w8frLmBR_A0r+T76w7rB4QUJPqR774@mail.gmail.com>
	<AANLkTi==vQDpmFmiYU9-S1Zh=nZdygRMMvpJHpJN_7gR@mail.gmail.com>
In-Reply-To: <AANLkTi==vQDpmFmiYU9-S1Zh=nZdygRMMvpJHpJN_7gR@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 15/19] savevm: introduce
	qemu_savevm_trans_{begin, commit}.
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Yoshiaki Tamura <tamura.yoshiaki@lab.ntt.co.jp>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org

On 02/01/2011 07:21 PM, Yoshiaki Tamura wrote:
> Paolo,
>
> I refactored the savevm functions.  Could you give me your
> comments?

I didn't review it thoroughly, but the abstractions seem okay.

Paolo