From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=35866 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PkgZm-0004rp-3f
	for qemu-devel@nongnu.org; Wed, 02 Feb 2011 12:33:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1PkgZk-00072Q-VG
	for qemu-devel@nongnu.org; Wed, 02 Feb 2011 12:33:05 -0500
Received: from mail-yi0-f45.google.com ([209.85.218.45]:35152)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1PkgZk-00072K-RX
	for qemu-devel@nongnu.org; Wed, 02 Feb 2011 12:33:04 -0500
Received: by yie21 with SMTP id 21so113291yie.4
	for <qemu-devel@nongnu.org>; Wed, 02 Feb 2011 09:33:04 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4D49954B.1090002@redhat.com>
Date: Wed, 02 Feb 2011 18:32:59 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1295902845-29807-1-git-send-email-aliguori@us.ibm.com>
	<1295902845-29807-4-git-send-email-aliguori@us.ibm.com>
In-Reply-To: <1295902845-29807-4-git-send-email-aliguori@us.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 3/7] Add support for glib based threading
 and convert qemu thread to use it
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Arun Bharadwaj <arun@linux.vnet.ibm.com>, Paul Brook <paul@codesourcery.com>, Marcelo Tosatti <mtosatti@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>

On 01/24/2011 10:00 PM, Anthony Liguori wrote:
>   int qemu_mutex_trylock(QemuMutex *mutex)
>   {
> -    return pthread_mutex_trylock(&mutex->lock);
> +    return g_static_mutex_trylock(&mutex->lock);

This is missing a !

Paolo