From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=36941 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PkgcD-00064n-3n
	for qemu-devel@nongnu.org; Wed, 02 Feb 2011 12:35:40 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aliguori@linux.vnet.ibm.com>) id 1Pkgbx-0007Zg-0J
	for qemu-devel@nongnu.org; Wed, 02 Feb 2011 12:35:22 -0500
Received: from e4.ny.us.ibm.com ([32.97.182.144]:33292)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aliguori@linux.vnet.ibm.com>) id 1Pkgbw-0007ZB-UH
	for qemu-devel@nongnu.org; Wed, 02 Feb 2011 12:35:20 -0500
Received: from d01dlp01.pok.ibm.com (d01dlp01.pok.ibm.com [9.56.224.56])
	by e4.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id p12HGD54005746
	for <qemu-devel@nongnu.org>; Wed, 2 Feb 2011 12:16:51 -0500
Received: from d01relay03.pok.ibm.com (d01relay03.pok.ibm.com [9.56.227.235])
	by d01dlp01.pok.ibm.com (Postfix) with ESMTP id 3E9CE728068
	for <qemu-devel@nongnu.org>; Wed,  2 Feb 2011 12:35:12 -0500 (EST)
Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215])
	by d01relay03.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	p12HZBIj340066
	for <qemu-devel@nongnu.org>; Wed, 2 Feb 2011 12:35:11 -0500
Received: from d01av01.pok.ibm.com (loopback [127.0.0.1])
	by d01av01.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	p12HZBHR022096
	for <qemu-devel@nongnu.org>; Wed, 2 Feb 2011 12:35:11 -0500
Message-ID: <4D4995CD.5080607@linux.vnet.ibm.com>
Date: Wed, 02 Feb 2011 11:35:09 -0600
From: Anthony Liguori <aliguori@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <1295902845-29807-1-git-send-email-aliguori@us.ibm.com>
	<1295902845-29807-4-git-send-email-aliguori@us.ibm.com>
	<4D49954B.1090002@redhat.com>
In-Reply-To: <4D49954B.1090002@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 3/7] Add support for glib based threading
 and convert qemu thread to use it
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, Marcelo Tosatti <mtosatti@redhat.com>, qemu-devel@nongnu.org, Paul Brook <paul@codesourcery.com>, Arun Bharadwaj <arun@linux.vnet.ibm.com>

On 02/02/2011 11:32 AM, Paolo Bonzini wrote:
> On 01/24/2011 10:00 PM, Anthony Liguori wrote:
>>   int qemu_mutex_trylock(QemuMutex *mutex)
>>   {
>> -    return pthread_mutex_trylock(&mutex->lock);
>> +    return g_static_mutex_trylock(&mutex->lock);
>
> This is missing a !

Good catch.

Regards,

Anthony Liguori

>
> Paolo