* [Qemu-devel] [PATCH 0.14] Fix build on 32 bit hosts
@ 2011-02-02 19:05 Blue Swirl
2011-02-02 20:35 ` [Qemu-devel] [PATCH] x86: Fix MCA broadcast parameters for TCG case Jan Kiszka
0 siblings, 1 reply; 3+ messages in thread
From: Blue Swirl @ 2011-02-02 19:05 UTC (permalink / raw)
To: qemu-devel
Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
---
target-i386/helper.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/target-i386/helper.c b/target-i386/helper.c
index 1217452..4bbf9b1 100644
--- a/target-i386/helper.c
+++ b/target-i386/helper.c
@@ -1148,7 +1148,7 @@ void cpu_inject_x86_mce(CPUState *cenv, int
bank, uint64_t status,
continue;
}
- qemu_inject_x86_mce(env, 1, 0xa000000000000000, 0, 0, 0);
+ qemu_inject_x86_mce(env, 1, 0xa000000000000000ULL, 0, 0, 0);
}
}
}
--
1.6.2.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Qemu-devel] [PATCH] x86: Fix MCA broadcast parameters for TCG case
2011-02-02 19:05 [Qemu-devel] [PATCH 0.14] Fix build on 32 bit hosts Blue Swirl
@ 2011-02-02 20:35 ` Jan Kiszka
2011-02-04 13:58 ` [Qemu-devel] " Marcelo Tosatti
0 siblings, 1 reply; 3+ messages in thread
From: Jan Kiszka @ 2011-02-02 20:35 UTC (permalink / raw)
To: Blue Swirl
Cc: Hidetoshi Seto, kvm, Marcelo Tosatti, qemu-devel, Avi Kivity,
Huang Ying, Jin Dongming
On 2011-02-02 20:05, Blue Swirl wrote:
> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
> ---
> target-i386/helper.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/target-i386/helper.c b/target-i386/helper.c
> index 1217452..4bbf9b1 100644
> --- a/target-i386/helper.c
> +++ b/target-i386/helper.c
> @@ -1148,7 +1148,7 @@ void cpu_inject_x86_mce(CPUState *cenv, int
> bank, uint64_t status,
> continue;
> }
>
> - qemu_inject_x86_mce(env, 1, 0xa000000000000000, 0, 0, 0);
> + qemu_inject_x86_mce(env, 1, 0xa000000000000000ULL, 0, 0, 0);
> }
> }
> }
Let's fix this for real, the value is wrong anyway:
----------8<----------
From: Jan Kiszka <jan.kiszka@siemens.com>
When broadcasting MCEs, we need to set MCIP and RIPV in mcg_status like
it is done for KVM. Use the symbolic constants at this chance.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
target-i386/helper.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/target-i386/helper.c b/target-i386/helper.c
index d74b6e3..f41416f 100644
--- a/target-i386/helper.c
+++ b/target-i386/helper.c
@@ -1145,8 +1145,8 @@ void cpu_inject_x86_mce(CPUState *cenv, int bank, uint64_t status,
if (cenv == env) {
continue;
}
-
- qemu_inject_x86_mce(env, 1, 0xa000000000000000, 0, 0, 0);
+ qemu_inject_x86_mce(env, 1, MCI_STATUS_VAL | MCI_STATUS_UC,
+ MCG_STATUS_MCIP | MCG_STATUS_RIPV, 0, 0);
}
}
}
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Qemu-devel] Re: [PATCH] x86: Fix MCA broadcast parameters for TCG case
2011-02-02 20:35 ` [Qemu-devel] [PATCH] x86: Fix MCA broadcast parameters for TCG case Jan Kiszka
@ 2011-02-04 13:58 ` Marcelo Tosatti
0 siblings, 0 replies; 3+ messages in thread
From: Marcelo Tosatti @ 2011-02-04 13:58 UTC (permalink / raw)
To: Jan Kiszka
Cc: Hidetoshi Seto, kvm, qemu-devel, Blue Swirl, Avi Kivity,
Huang Ying, Jin Dongming
On Wed, Feb 02, 2011 at 09:35:26PM +0100, Jan Kiszka wrote:
> On 2011-02-02 20:05, Blue Swirl wrote:
> > Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
> > ---
> > target-i386/helper.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/target-i386/helper.c b/target-i386/helper.c
> > index 1217452..4bbf9b1 100644
> > --- a/target-i386/helper.c
> > +++ b/target-i386/helper.c
> > @@ -1148,7 +1148,7 @@ void cpu_inject_x86_mce(CPUState *cenv, int
> > bank, uint64_t status,
> > continue;
> > }
> >
> > - qemu_inject_x86_mce(env, 1, 0xa000000000000000, 0, 0, 0);
> > + qemu_inject_x86_mce(env, 1, 0xa000000000000000ULL, 0, 0, 0);
> > }
> > }
> > }
>
> Let's fix this for real, the value is wrong anyway:
>
> ----------8<----------
>
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> When broadcasting MCEs, we need to set MCIP and RIPV in mcg_status like
> it is done for KVM. Use the symbolic constants at this chance.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Applied to uq/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-02-04 14:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-02 19:05 [Qemu-devel] [PATCH 0.14] Fix build on 32 bit hosts Blue Swirl
2011-02-02 20:35 ` [Qemu-devel] [PATCH] x86: Fix MCA broadcast parameters for TCG case Jan Kiszka
2011-02-04 13:58 ` [Qemu-devel] " Marcelo Tosatti
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).