From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=39593 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PkjQL-00034S-BU for qemu-devel@nongnu.org; Wed, 02 Feb 2011 15:35:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PkjQJ-0001Up-Gy for qemu-devel@nongnu.org; Wed, 02 Feb 2011 15:35:32 -0500 Received: from fmmailgate02.web.de ([217.72.192.227]:54801) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PkjQI-0001TQ-Tu for qemu-devel@nongnu.org; Wed, 02 Feb 2011 15:35:31 -0500 Message-ID: <4D49C00E.6090104@web.de> Date: Wed, 02 Feb 2011 21:35:26 +0100 From: Jan Kiszka MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: jan.kiszka@web.de Subject: [Qemu-devel] [PATCH] x86: Fix MCA broadcast parameters for TCG case List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: Hidetoshi Seto , kvm , Marcelo Tosatti , qemu-devel , Avi Kivity , Huang Ying , Jin Dongming On 2011-02-02 20:05, Blue Swirl wrote: > Signed-off-by: Blue Swirl > --- > target-i386/helper.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/target-i386/helper.c b/target-i386/helper.c > index 1217452..4bbf9b1 100644 > --- a/target-i386/helper.c > +++ b/target-i386/helper.c > @@ -1148,7 +1148,7 @@ void cpu_inject_x86_mce(CPUState *cenv, int > bank, uint64_t status, > continue; > } > > - qemu_inject_x86_mce(env, 1, 0xa000000000000000, 0, 0, 0); > + qemu_inject_x86_mce(env, 1, 0xa000000000000000ULL, 0, 0, 0); > } > } > } Let's fix this for real, the value is wrong anyway: ----------8<---------- From: Jan Kiszka When broadcasting MCEs, we need to set MCIP and RIPV in mcg_status like it is done for KVM. Use the symbolic constants at this chance. Signed-off-by: Jan Kiszka --- target-i386/helper.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target-i386/helper.c b/target-i386/helper.c index d74b6e3..f41416f 100644 --- a/target-i386/helper.c +++ b/target-i386/helper.c @@ -1145,8 +1145,8 @@ void cpu_inject_x86_mce(CPUState *cenv, int bank, uint64_t status, if (cenv == env) { continue; } - - qemu_inject_x86_mce(env, 1, 0xa000000000000000, 0, 0, 0); + qemu_inject_x86_mce(env, 1, MCI_STATUS_VAL | MCI_STATUS_UC, + MCG_STATUS_MCIP | MCG_STATUS_RIPV, 0, 0); } } } -- 1.7.1