From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=59596 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PlS7u-0001yd-0c
	for qemu-devel@nongnu.org; Fri, 04 Feb 2011 15:19:30 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1PlS7s-0006Kc-MS
	for qemu-devel@nongnu.org; Fri, 04 Feb 2011 15:19:29 -0500
Received: from mail-iy0-f173.google.com ([209.85.210.173]:43821)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1PlS7s-0006KW-EM
	for qemu-devel@nongnu.org; Fri, 04 Feb 2011 15:19:28 -0500
Received: by iye19 with SMTP id 19so2666848iye.4
	for <qemu-devel@nongnu.org>; Fri, 04 Feb 2011 12:19:27 -0800 (PST)
Message-ID: <4D4C5F47.8060700@codemonkey.ws>
Date: Fri, 04 Feb 2011 14:19:19 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] block/vdi: Fix wrong size in conditionally
	used memset, memcmp
References: <1296849676-7429-1-git-send-email-weil@mail.berlios.de>
In-Reply-To: <1296849676-7429-1-git-send-email-weil@mail.berlios.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: Kevin Wolf <kwolf@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>

On 02/04/2011 02:01 PM, Stefan Weil wrote:
> Error report from cppcheck:
> block/vdi.c:122: error: Using sizeof for array given as function argument returns the size of pointer.
> block/vdi.c:128: error: Using sizeof for array given as function argument returns the size of pointer.
>
> Fix both by setting the correct size.
>
> The buggy code is only used when QEMU is build without uuid support.
> The bug is not critical, so there is no urgent need to apply it to
> old versions of QEMU.
>
> Cc: Kevin Wolf<kwolf@redhat.com>
> Signed-off-by: Stefan Weil<weil@mail.berlios.de>
>    

Huh, I wouldn't have thought this was the case.  I almost feel that 
doing a #define UUID_SIZE may be better because sizeof(typeof(v)) != 
sizeof(v) is weird even by C standards.

Regards,

Anthony Liguori

> ---
>   block/vdi.c |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/block/vdi.c b/block/vdi.c
> index 83b9c04..083266e 100644
> --- a/block/vdi.c
> +++ b/block/vdi.c
> @@ -119,13 +119,13 @@ void uuid_unparse(const uuid_t uu, char *out);
>   #if !defined(CONFIG_UUID)
>   void uuid_generate(uuid_t out)
>   {
> -    memset(out, 0, sizeof(out));
> +    memset(out, 0, sizeof(uuid_t));
>   }
>
>   int uuid_is_null(const uuid_t uu)
>   {
>       uuid_t null_uuid = { 0 };
> -    return memcmp(uu, null_uuid, sizeof(uu)) == 0;
> +    return memcmp(uu, null_uuid, sizeof(uuid_t)) == 0;
>   }
>
>   void uuid_unparse(const uuid_t uu, char *out)
>