From: Jan Kiszka <jan.kiszka@web.de>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [trivial PATCH 0.14+] fix compile error on i386
Date: Sat, 05 Feb 2011 11:48:28 +0100 [thread overview]
Message-ID: <4D4D2AFC.2040107@web.de> (raw)
In-Reply-To: <20110205092735.201CB12B63@gandalf.tls.msk.ru>
[-- Attachment #1: Type: text/plain, Size: 905 bytes --]
On 2011-02-05 10:27, Michael Tokarev wrote:
> When compiling on i386 (32bit) compiler choles on this:
>
> CC x86_64-softmmu/helper.o
> cc1: warnings being treated as errors
> target-i386/helper.c: In function 'cpu_inject_x86_mce':
> target-i386/helper.c:1153: error: integer constant is too large for 'long' type
>
> qemu_inject_x86_mce() accepts uint64_t as 3rd arg, so we have to add ULL
> to fix the invocation.
>
> Signed-Off-By: Michael Tokarev <mjt@tls.msk.ru>
>
> --- a/target-i386/helper.c
> +++ b/target-i386/helper.c
> @@ -1152,3 +1152,3 @@
>
> - qemu_inject_x86_mce(env, 1, 0xa000000000000000, 0, 0, 0);
> + qemu_inject_x86_mce(env, 1, 0xa000000000000000ULL, 0, 0, 0);
> }
>
The original value is wrong. [1] should get merged into 0.14.
Jan
[1] http://article.gmane.org/gmane.comp.emulators.kvm.devel/67445
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
next prev parent reply other threads:[~2011-02-05 10:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-05 9:27 [Qemu-devel] [trivial PATCH 0.14+] fix compile error on i386 Michael Tokarev
2011-02-05 10:48 ` Jan Kiszka [this message]
2011-02-08 8:10 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D4D2AFC.2040107@web.de \
--to=jan.kiszka@web.de \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).