From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=41592 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Plfgy-0005WL-Oc for qemu-devel@nongnu.org; Sat, 05 Feb 2011 05:48:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Plfgx-0007qD-OJ for qemu-devel@nongnu.org; Sat, 05 Feb 2011 05:48:36 -0500 Received: from fmmailgate03.web.de ([217.72.192.234]:45872) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Plfgx-0007pv-9s for qemu-devel@nongnu.org; Sat, 05 Feb 2011 05:48:35 -0500 Message-ID: <4D4D2AFC.2040107@web.de> Date: Sat, 05 Feb 2011 11:48:28 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <20110205092735.201CB12B63@gandalf.tls.msk.ru> In-Reply-To: <20110205092735.201CB12B63@gandalf.tls.msk.ru> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigD5E963ECD023B132721EDBE4" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: [trivial PATCH 0.14+] fix compile error on i386 List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigD5E963ECD023B132721EDBE4 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable On 2011-02-05 10:27, Michael Tokarev wrote: > When compiling on i386 (32bit) compiler choles on this: >=20 > CC x86_64-softmmu/helper.o > cc1: warnings being treated as errors > target-i386/helper.c: In function 'cpu_inject_x86_mce': > target-i386/helper.c:1153: error: integer constant is too large for 'lo= ng' type >=20 > qemu_inject_x86_mce() accepts uint64_t as 3rd arg, so we have to add UL= L > to fix the invocation. >=20 > Signed-Off-By: Michael Tokarev >=20 > --- a/target-i386/helper.c > +++ b/target-i386/helper.c > @@ -1152,3 +1152,3 @@ > =20 > - qemu_inject_x86_mce(env, 1, 0xa000000000000000, 0, 0, = 0); > + qemu_inject_x86_mce(env, 1, 0xa000000000000000ULL, 0, = 0, 0); > } >=20 The original value is wrong. [1] should get merged into 0.14. Jan [1] http://article.gmane.org/gmane.comp.emulators.kvm.devel/67445 --------------enigD5E963ECD023B132721EDBE4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iEYEARECAAYFAk1NKv8ACgkQitSsb3rl5xSxPQCgzgaOqKgAcxXdBWyDVusL8m6d SAgAn3ghY41xVNdiU9ZwnzBNsrLdRI60 =3qzJ -----END PGP SIGNATURE----- --------------enigD5E963ECD023B132721EDBE4--