From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=53532 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PmOA1-00042w-RW
	for qemu-devel@nongnu.org; Mon, 07 Feb 2011 05:17:35 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <christophe.lyon@st.com>) id 1PmO9z-00014V-PF
	for qemu-devel@nongnu.org; Mon, 07 Feb 2011 05:17:32 -0500
Received: from eu1sys200aog111.obsmtp.com ([207.126.144.131]:56158)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <christophe.lyon@st.com>) id 1PmO9z-00012A-Ef
	for qemu-devel@nongnu.org; Mon, 07 Feb 2011 05:17:31 -0500
Message-ID: <4D4FC69D.9040905@st.com>
Date: Mon, 7 Feb 2011 11:17:01 +0100
From: Christophe Lyon <christophe.lyon@st.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Softfloat: Add support to softfloat to return
	floatxx_default_nan when the corresponding target status flag is set.
References: <4D4C06CD.4060900@st.com>
	<AANLkTikYh1LFmc4e4DCDpYNxCwxAyazsmG+xZfTmZ89M@mail.gmail.com>
	<20110204194702.GB10125@volta.aurel32.net>
In-Reply-To: <20110204194702.GB10125@volta.aurel32.net>
Content-Type: text/plain; charset="ISO-8859-15"
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: Peter Maydell <peter.maydell@linaro.org>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On 04.02.2011 20:47, Aurelien Jarno wrote:
> On Fri, Feb 04, 2011 at 02:44:48PM +0000, Peter Maydell wrote:
>> On 4 February 2011 14:01, Christophe Lyon <christophe.lyon@st.com> wrote:
>>
>> The target-specific #ifdef is pretty ugly.
I wanted to be safe (not breaking other targets), and as there are already some #ifdef in the same file, it seemed acceptable ;-)


> 
> I confirm that the same bug is present on SH4 (tested on real hardware),
> so the same fix is needed there. Thanks for catching that. Can you
> please resend your patch without the #ifdef?
> 
OK

>> (cc'ing Aurelien to check since he's the SH4 maintainer.)
>>
>> I also think the change is simple enough that we ought to do
>> it consistently for the floatx80 and float128 functions even if
>> neither ARM nor sh4 use them.
>>
> 
> Agreed.
> 
OK.

I was also wondering about the float16 case? The ARM ARM describes it uses default_nan too, but I couldn't find that right piece of code to patch in softfloat. Any idea? It seems to behave a bit differently from other FP formats.

Christophe.