From: Avi Kivity <avi@redhat.com>
To: Glauber Costa <glommer@redhat.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: [Qemu-devel] Re: [PATCH 15/15] kvm: x86: Introduce kvmclock device to save/restore its state
Date: Mon, 07 Feb 2011 14:44:17 +0200 [thread overview]
Message-ID: <4D4FE921.8030805@redhat.com> (raw)
In-Reply-To: <1297081668.14123.2.camel@mothafucka.localdomain>
On 02/07/2011 02:27 PM, Glauber Costa wrote:
> >
> What exactly is your motivation to that ? I think mid/long-term
> we should be making machine initialization more common among
> architectures, not introducing more arch specific, or even worse, kvm
> specific parameters here.
>
A general note: there are several ways of being "kvm specific"; one of
them is being tied to the implementation of kvm as the implementation of
a virtual cpu in qemu. Another, with an example here, is a cpu feature
that is only (or at first) present in kvm, but in principle may be
supported by any cpu implementation, like tcg or a real cpu. It's
important not to confuse the two; only the first needs all those hooks
tied into the -accel infrastructure.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-02-07 12:44 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-07 11:19 [Qemu-devel] [PATCH 00/15] [uq/master] Patch queue, part III Jan Kiszka
2011-02-07 11:19 ` [Qemu-devel] [PATCH 01/15] Refactor kvm&tcg function names in cpus.c Jan Kiszka
2011-02-07 11:19 ` [Qemu-devel] [PATCH 02/15] Refactor cpu_has_work/any_cpu_has_work " Jan Kiszka
2011-02-08 18:50 ` [Qemu-devel] " Marcelo Tosatti
2011-02-09 8:07 ` Jan Kiszka
2011-02-09 13:54 ` Marcelo Tosatti
2011-02-09 15:29 ` [Qemu-devel] [PATCH v2 " Jan Kiszka
2011-02-07 11:19 ` [Qemu-devel] [PATCH 03/15] Fix a few coding style violations " Jan Kiszka
2011-02-07 11:19 ` [Qemu-devel] [PATCH 04/15] Improve vm_stop reason declarations Jan Kiszka
2011-02-08 18:59 ` [Qemu-devel] " Marcelo Tosatti
2011-02-09 8:07 ` Jan Kiszka
2011-02-09 14:17 ` Marcelo Tosatti
2011-02-09 14:51 ` Jan Kiszka
2011-02-09 15:29 ` [Qemu-devel] [PATCH v2 " Jan Kiszka
2011-02-07 11:19 ` [Qemu-devel] [PATCH 05/15] Refactor debug and vmstop request interface Jan Kiszka
2011-02-07 11:19 ` [Qemu-devel] [PATCH 06/15] Move debug exception handling out of cpu_exec Jan Kiszka
2011-02-07 11:19 ` [Qemu-devel] [PATCH 07/15] kvm: Separate TCG from KVM cpu execution Jan Kiszka
2011-02-08 23:39 ` [Qemu-devel] " Marcelo Tosatti
2011-02-09 7:59 ` Jan Kiszka
2011-02-09 14:44 ` Marcelo Tosatti
2011-02-09 14:53 ` Jan Kiszka
2011-02-07 11:19 ` [Qemu-devel] [PATCH 08/15] kvm: x86: Prepare VCPU loop for in-kernel irqchip Jan Kiszka
2011-02-07 11:19 ` [Qemu-devel] [PATCH 09/15] kvm: Drop return values from kvm_arch_pre/post_run Jan Kiszka
2011-02-07 12:54 ` [Qemu-devel] " Alexander Graf
2011-02-17 21:01 ` [Qemu-devel] [PATCH] kvm: ppc: Fix breakage of kvm_arch_pre_run/process_irqchip_events Jan Kiszka
2011-03-11 5:55 ` [Qemu-devel] " Alexander Graf
2011-03-11 6:26 ` Stefan Hajnoczi
2011-03-11 7:02 ` Alexander Graf
2011-02-07 11:19 ` [Qemu-devel] [PATCH 10/15] kvm: x86: Catch and report failing IRQ and NMI injections Jan Kiszka
2011-02-07 11:19 ` [Qemu-devel] [PATCH 11/15] kvm: Remove unneeded memory slot reservation Jan Kiszka
2011-02-07 15:26 ` [Qemu-devel] " Alex Williamson
2011-02-07 11:19 ` [Qemu-devel] [PATCH 12/15] Introduce log_start/log_stop in CPUPhysMemoryClient Jan Kiszka
2011-02-07 11:19 ` [Qemu-devel] [PATCH 13/15] cirrus: Remove obsolete kvm.h include Jan Kiszka
2011-02-07 11:19 ` [Qemu-devel] [PATCH 14/15] kvm: Make kvm_state globally available Jan Kiszka
2011-02-07 11:19 ` [Qemu-devel] [PATCH 15/15] kvm: x86: Introduce kvmclock device to save/restore its state Jan Kiszka
2011-02-07 12:27 ` [Qemu-devel] " Glauber Costa
2011-02-07 12:36 ` Jan Kiszka
2011-02-07 13:40 ` Glauber Costa
2011-02-07 14:03 ` Jan Kiszka
2011-02-07 18:04 ` Glauber Costa
2011-02-07 18:12 ` Jan Kiszka
2011-02-07 18:26 ` Glauber Costa
2011-02-07 12:44 ` Avi Kivity [this message]
2011-02-07 19:39 ` [Qemu-devel] " Blue Swirl
2011-02-07 21:48 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D4FE921.8030805@redhat.com \
--to=avi@redhat.com \
--cc=glommer@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).