From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=36576 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PmQSB-0007zg-8W for qemu-devel@nongnu.org; Mon, 07 Feb 2011 07:44:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PmQS8-0001O0-5F for qemu-devel@nongnu.org; Mon, 07 Feb 2011 07:44:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:23136) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PmQS7-0001Nu-Ti for qemu-devel@nongnu.org; Mon, 07 Feb 2011 07:44:24 -0500 Message-ID: <4D4FE921.8030805@redhat.com> Date: Mon, 07 Feb 2011 14:44:17 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1297081668.14123.2.camel@mothafucka.localdomain> In-Reply-To: <1297081668.14123.2.camel@mothafucka.localdomain> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 15/15] kvm: x86: Introduce kvmclock device to save/restore its state List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Glauber Costa Cc: Jan Kiszka , Marcelo Tosatti , qemu-devel@nongnu.org, kvm@vger.kernel.org On 02/07/2011 02:27 PM, Glauber Costa wrote: > > > What exactly is your motivation to that ? I think mid/long-term > we should be making machine initialization more common among > architectures, not introducing more arch specific, or even worse, kvm > specific parameters here. > A general note: there are several ways of being "kvm specific"; one of them is being tied to the implementation of kvm as the implementation of a virtual cpu in qemu. Another, with an example here, is a cpu feature that is only (or at first) present in kvm, but in principle may be supported by any cpu implementation, like tcg or a real cpu. It's important not to confuse the two; only the first needs all those hooks tied into the -accel infrastructure. -- error compiling committee.c: too many arguments to function