From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=40992 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PmSqK-00069S-10
	for qemu-devel@nongnu.org; Mon, 07 Feb 2011 10:17:34 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1PmSqI-00032i-Ul
	for qemu-devel@nongnu.org; Mon, 07 Feb 2011 10:17:31 -0500
Received: from goliath.siemens.de ([192.35.17.28]:34425)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1PmSqI-00032H-Go
	for qemu-devel@nongnu.org; Mon, 07 Feb 2011 10:17:30 -0500
Message-ID: <4D500D08.5020709@siemens.com>
Date: Mon, 07 Feb 2011 16:17:28 +0100
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [RFC: 0/2] patch for QEMU HPET periodic timer
	emulation to alleviate time drift
References: <480481933.225059.1296734409954.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com>	<1375835067.226263.1296740625327.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com>	<4D4AC99A.2070803@siemens.com>	<4D4B0B07.2040904@codemonkey.ws>	<4D4B1CF8.8040800@web.de>	<4D4B5F23.7040801@codemonkey.ws>	<4D4BBF55.9060000@web.de>	<4D4FE6BF.5080502@redhat.com>	<4D4FEF81.1040603@codemonkey.ws>	<4D4FF02F.2030309@redhat.com>	<4D4FF24A.7000004@codemonkey.ws>
	<4D4FFD3B.2030903@siemens.com>	<4D5001A0.8020503@codemonkey.ws>
	<4D5004FC.80000@siemens.com>	<4D5007B9.7060806@codemonkey.ws>
	<4D500872.3070506@siemens.com> <4D50092C.1080109@codemonkey.ws>
	<4D500C1A.1070506@redhat.com>
In-Reply-To: <4D500C1A.1070506@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: kvm <kvm@vger.kernel.org>, Glauber Costa <glommer@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, Ulrich Obergfell <uobergfe@redhat.com>

On 2011-02-07 16:13, Avi Kivity wrote:
> On 02/07/2011 05:01 PM, Anthony Liguori wrote:
>>
>> typedef struct PeriodicTimer PeriodicTimer;
>>
>> /**
>>  * @accumulated_ticks:  the number of unacknowledged ticks in total 
>> since the creation of the timer
>>  **/
> 
> Outdated comment even before the code is committed.  Will be hard to beat.
> 
>> typedef void (PeriodicTimerFunc)(void *opaque);
> 
> s/void *opaque/PeriodicTimer *timer/
> 
> Down with opaques!

What else? DeviceState?

> 
>>
>> PeriodicTimer *periodic_timer_new(PeriodicTimerFunc *cb, void *opaque);
>>
> 
> void periodic_timer_init(PeriodicTimer *timer, PeriodicTimerFunc *cb);
> 
> It is better to embed than to reference.

Likely, though this diverges from exiting QEMUTimer.

BTW, QEMUClock argument is missing in new/init.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux