From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=60480 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PmTSB-0005Rn-IE for qemu-devel@nongnu.org; Mon, 07 Feb 2011 10:56:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PmTS9-0003Ma-Oh for qemu-devel@nongnu.org; Mon, 07 Feb 2011 10:56:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:1880) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PmTS9-0003ME-E7 for qemu-devel@nongnu.org; Mon, 07 Feb 2011 10:56:37 -0500 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p17FuaMm020325 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 7 Feb 2011 10:56:36 -0500 Message-ID: <4D50162E.1060104@redhat.com> Date: Mon, 07 Feb 2011 08:56:30 -0700 From: Eric Blake MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 00/16] usb-ccid (v18) References: <1296773152-23279-1-git-send-email-alevy@redhat.com> <20110207110306.GC5754@playa.tlv.redhat.com> <4D4FEFD4.3090109@codemonkey.ws> <20110207154413.GA4454@playa.tlv.redhat.com> In-Reply-To: <20110207154413.GA4454@playa.tlv.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigB81FD15F62AC05EAB4C22DBC" List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, "libvir-list@redhat.com" This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigB81FD15F62AC05EAB4C22DBC Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable [adding libvir-list as well] On 02/07/2011 08:44 AM, Alon Levy wrote: >>> I guess I'll wait a little longer for more feedback? Should I split >>> the enum property separately? it's only used by ccid-card-emualted at= m. >> >> The only non-cosmetic concern I have about your series is the enum >> property so I would strongly suggest splitting it. If you did that >> for v19, it will be pretty close to merge ready. >> >=20 > Eric, >=20 > How does this affect libvirt? could you assume a default set of backen= ds > if "-device ccid-card-emulated,?" returns "backend=3Dstring" instead of= > "backend=3DA/B" ? Hmm. At the moment, libvirt only looks for "ccid-card-emulated" in the -device ? list, and hasn't yet tried inspecting -device ccid-card-emulated,? output. In short, libvirt assumes that the presence of ccid-card-emulated implies that both modes are available (libvirt's =3D> backend=3Dnss-emulated; backend=3Dcertificates). Is it possible = for qemu to have support for one, but not both, of those modes? If that's the case, then supporting "backend=3Dnss-emulated/certificates" in -devic= e ccid-card-emulated,? would be handy for libvirt (for example, it would be just "backend=3Dcertificates" if nss-emulated is not available). But if it's an all-or-none approach (all backends are available if ccid-card-emulated is present), then libvirt's current code won't be impacted by changing the string to the simpler "backend=3Dstring". --=20 Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org --------------enigB81FD15F62AC05EAB4C22DBC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJNUBYuAAoJEKeha0olJ0Nq65MIAJzFDe05n0LgLoBrJ3lM6s2Y AdoD2CxTI5Q2iyON7tBi1K7s3hKcSRipflI/ab3LeMHTSOAOPy866aV0N+iq1iZx JgTkjFTEWlO7o3Tman3557tU7qlQH2sF4cvlDzVSoa1tUB5X8i087kKsGS5tb/Tv LMSEJrTlZD4opyELvVn7m+L9hfxRJhtzy+U3ZoFxocOqVm27gxv3kKGWGHKgmySs PNnvEPQQLLh+xV8ep/xrn8klUR6jdlMwtGHnWWeuD3GhBQUNA8KKLeQztDR/IviB k/OCUOZMFEnXKkMr17oADncaBNLe1+Exq7k0kJ0iD6qR5b3hMW7lOpb/VNDZhaA= =PayL -----END PGP SIGNATURE----- --------------enigB81FD15F62AC05EAB4C22DBC--