From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=39656 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PmYJd-0008FZ-GT for qemu-devel@nongnu.org; Mon, 07 Feb 2011 16:08:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PmWod-0000Ye-Ok for qemu-devel@nongnu.org; Mon, 07 Feb 2011 14:32:04 -0500 Received: from mail-wy0-f173.google.com ([74.125.82.173]:54177) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PmWod-0000YO-JT for qemu-devel@nongnu.org; Mon, 07 Feb 2011 14:32:03 -0500 Received: by wyg36 with SMTP id 36so5128377wyg.4 for ; Mon, 07 Feb 2011 11:32:02 -0800 (PST) Message-ID: <4D5048A7.20004@codemonkey.ws> Date: Mon, 07 Feb 2011 13:31:51 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 00/16] usb-ccid (v18) References: <1296773152-23279-1-git-send-email-alevy@redhat.com> <20110207110306.GC5754@playa.tlv.redhat.com> <4D4FEFD4.3090109@codemonkey.ws> <20110207154413.GA4454@playa.tlv.redhat.com> <4D50162E.1060104@redhat.com> In-Reply-To: <4D50162E.1060104@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: "libvir-list@redhat.com" , qemu-devel@nongnu.org On 02/07/2011 09:56 AM, Eric Blake wrote: > [adding libvir-list as well] > > On 02/07/2011 08:44 AM, Alon Levy wrote: > >>>> I guess I'll wait a little longer for more feedback? Should I split >>>> the enum property separately? it's only used by ccid-card-emualted atm. >>>> >>> The only non-cosmetic concern I have about your series is the enum >>> property so I would strongly suggest splitting it. If you did that >>> for v19, it will be pretty close to merge ready. >>> >>> >> Eric, >> >> How does this affect libvirt? could you assume a default set of backends >> if "-device ccid-card-emulated,?" returns "backend=string" instead of >> "backend=A/B" ? >> > Hmm. At the moment, libvirt only looks for "ccid-card-emulated" in the > -device ? list, and hasn't yet tried inspecting -device > ccid-card-emulated,? output. In short, libvirt assumes that the > presence of ccid-card-emulated implies that both modes are available > (libvirt's => backend=nss-emulated; mode='host-certificates' => backend=certificates). Why is libvirt assuming anything about a feature that isn't in upstream QEMU? Regards, Anthony Liguori > Is it possible for > qemu to have support for one, but not both, of those modes? If that's > the case, then supporting "backend=nss-emulated/certificates" in -device > ccid-card-emulated,? would be handy for libvirt (for example, it would > be just "backend=certificates" if nss-emulated is not available). But > if it's an all-or-none approach (all backends are available if > ccid-card-emulated is present), then libvirt's current code won't be > impacted by changing the string to the simpler "backend=string". > >