From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=48242 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PmdHH-0007Yh-2U
	for qemu-devel@nongnu.org; Mon, 07 Feb 2011 21:26:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1PmdHF-00018R-QT
	for qemu-devel@nongnu.org; Mon, 07 Feb 2011 21:26:02 -0500
Received: from mail-wy0-f173.google.com ([74.125.82.173]:36010)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1PmdHF-00017q-L3
	for qemu-devel@nongnu.org; Mon, 07 Feb 2011 21:26:01 -0500
Received: by wyg36 with SMTP id 36so5507848wyg.4
	for <qemu-devel@nongnu.org>; Mon, 07 Feb 2011 18:26:01 -0800 (PST)
Message-ID: <4D50A9B7.7040004@codemonkey.ws>
Date: Mon, 07 Feb 2011 20:25:59 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH master/0.14] virtio-serial: Make sure
	virtqueue is ready before discarding data
References: <f91470cb09ef21f7caeeb81eda407d498b3c1ad1.1296809653.git.amit.shah@redhat.com>	<4D4BF674.5050305@codemonkey.ws>	<20110206062046.GA1234@amit-x200.redhat.com>
	<20110208021422.GA691@amit-x200.redhat.com>
In-Reply-To: <20110208021422.GA691@amit-x200.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: qemu list <qemu-devel@nongnu.org>, Juan Quintela <quintela@redhat.com>

On 02/07/2011 08:14 PM, Amit Shah wrote:
> On (Sun) 06 Feb 2011 [11:50:46], Amit Shah wrote:
>    
>> On (Fri) 04 Feb 2011 [06:52:04], Anthony Liguori wrote:
>>      
>>> On 02/04/2011 02:54 AM, Amit Shah wrote:
>>>        
>>>> This can happen if a port gets unplugged before guest has chance to
>>>> initialise vqs.
>>>>
>>>> Reported-by: Juan Quintela<quintela@redhat.com>
>>>> Signed-off-by: Amit Shah<amit.shah@redhat.com>
>>>>          
>>> Applied to master, Thanks.
>>>        
>> What's the strategy to commit to 0.14?
>>      
> Nevermind; saw it in the last pull.
>    

Yes, but if we decide to make this a subsection, we may need to revert 
this before the 0.14.0 release because once 0.14.0 goes out, we can't go 
back and change it.

If that's how you want to approach it, then please send the revert 
patches.  The flow_control=0 patches you sent out before definitely 
aren't the right approach for migration compatibility.

Regards,

Anthony Liguori

> 		Amit
>
>