* [Qemu-devel] [trivial PATCH 0.14+] fix compile error on i386
@ 2011-02-05 9:27 Michael Tokarev
2011-02-05 10:48 ` [Qemu-devel] " Jan Kiszka
0 siblings, 1 reply; 3+ messages in thread
From: Michael Tokarev @ 2011-02-05 9:27 UTC (permalink / raw)
To: qemu-devel
When compiling on i386 (32bit) compiler choles on this:
CC x86_64-softmmu/helper.o
cc1: warnings being treated as errors
target-i386/helper.c: In function 'cpu_inject_x86_mce':
target-i386/helper.c:1153: error: integer constant is too large for 'long' type
qemu_inject_x86_mce() accepts uint64_t as 3rd arg, so we have to add ULL
to fix the invocation.
Signed-Off-By: Michael Tokarev <mjt@tls.msk.ru>
--- a/target-i386/helper.c
+++ b/target-i386/helper.c
@@ -1152,3 +1152,3 @@
- qemu_inject_x86_mce(env, 1, 0xa000000000000000, 0, 0, 0);
+ qemu_inject_x86_mce(env, 1, 0xa000000000000000ULL, 0, 0, 0);
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Qemu-devel] Re: [trivial PATCH 0.14+] fix compile error on i386
2011-02-05 9:27 [Qemu-devel] [trivial PATCH 0.14+] fix compile error on i386 Michael Tokarev
@ 2011-02-05 10:48 ` Jan Kiszka
2011-02-08 8:10 ` [Qemu-devel] " Michael Tokarev
0 siblings, 1 reply; 3+ messages in thread
From: Jan Kiszka @ 2011-02-05 10:48 UTC (permalink / raw)
To: Michael Tokarev; +Cc: qemu-devel
[-- Attachment #1: Type: text/plain, Size: 905 bytes --]
On 2011-02-05 10:27, Michael Tokarev wrote:
> When compiling on i386 (32bit) compiler choles on this:
>
> CC x86_64-softmmu/helper.o
> cc1: warnings being treated as errors
> target-i386/helper.c: In function 'cpu_inject_x86_mce':
> target-i386/helper.c:1153: error: integer constant is too large for 'long' type
>
> qemu_inject_x86_mce() accepts uint64_t as 3rd arg, so we have to add ULL
> to fix the invocation.
>
> Signed-Off-By: Michael Tokarev <mjt@tls.msk.ru>
>
> --- a/target-i386/helper.c
> +++ b/target-i386/helper.c
> @@ -1152,3 +1152,3 @@
>
> - qemu_inject_x86_mce(env, 1, 0xa000000000000000, 0, 0, 0);
> + qemu_inject_x86_mce(env, 1, 0xa000000000000000ULL, 0, 0, 0);
> }
>
The original value is wrong. [1] should get merged into 0.14.
Jan
[1] http://article.gmane.org/gmane.comp.emulators.kvm.devel/67445
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [trivial PATCH 0.14+] fix compile error on i386
2011-02-05 10:48 ` [Qemu-devel] " Jan Kiszka
@ 2011-02-08 8:10 ` Michael Tokarev
0 siblings, 0 replies; 3+ messages in thread
From: Michael Tokarev @ 2011-02-08 8:10 UTC (permalink / raw)
To: qemu-devel; +Cc: Anthony Liguori
http://article.gmane.org/gmane.comp.emulators.kvm.devel/67445 -- Ping?
qemu (0.14rc1) still can't be compiled on 32bit i386 host due to this.
/mjt
05.02.2011 13:48, Jan Kiszka wrote:
> On 2011-02-05 10:27, Michael Tokarev wrote:
>> When compiling on i386 (32bit) compiler choles on this:
>>
>> CC x86_64-softmmu/helper.o
>> cc1: warnings being treated as errors
>> target-i386/helper.c: In function 'cpu_inject_x86_mce':
>> target-i386/helper.c:1153: error: integer constant is too large for 'long' type
>>
>> qemu_inject_x86_mce() accepts uint64_t as 3rd arg, so we have to add ULL
>> to fix the invocation.
>>
>> Signed-Off-By: Michael Tokarev <mjt@tls.msk.ru>
>>
>> --- a/target-i386/helper.c
>> +++ b/target-i386/helper.c
>> @@ -1152,3 +1152,3 @@
>>
>> - qemu_inject_x86_mce(env, 1, 0xa000000000000000, 0, 0, 0);
>> + qemu_inject_x86_mce(env, 1, 0xa000000000000000ULL, 0, 0, 0);
>> }
>>
>
> The original value is wrong. [1] should get merged into 0.14.
>
> Jan
>
> [1] http://article.gmane.org/gmane.comp.emulators.kvm.devel/67445
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-02-08 8:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-05 9:27 [Qemu-devel] [trivial PATCH 0.14+] fix compile error on i386 Michael Tokarev
2011-02-05 10:48 ` [Qemu-devel] " Jan Kiszka
2011-02-08 8:10 ` [Qemu-devel] " Michael Tokarev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).