From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=50167 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Pmif8-0002zv-0a
	for qemu-devel@nongnu.org; Tue, 08 Feb 2011 03:11:02 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mjt@tls.msk.ru>) id 1Pmif7-0007Vq-2W
	for qemu-devel@nongnu.org; Tue, 08 Feb 2011 03:11:01 -0500
Received: from isrv.corpit.ru ([86.62.121.231]:49827)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mjt@tls.msk.ru>) id 1Pmif6-0007Vi-SP
	for qemu-devel@nongnu.org; Tue, 08 Feb 2011 03:11:01 -0500
Message-ID: <4D50FA90.807@msgid.tls.msk.ru>
Date: Tue, 08 Feb 2011 11:10:56 +0300
From: Michael Tokarev <mjt@tls.msk.ru>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [trivial PATCH 0.14+] fix compile error on i386
References: <20110205092735.201CB12B63@gandalf.tls.msk.ru>
	<4D4D2AFC.2040107@web.de>
In-Reply-To: <4D4D2AFC.2040107@web.de>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Anthony Liguori <aliguori@linux.vnet.ibm.com>

http://article.gmane.org/gmane.comp.emulators.kvm.devel/67445 -- Ping?
qemu (0.14rc1) still can't be compiled on 32bit i386 host due to this.

/mjt

05.02.2011 13:48, Jan Kiszka wrote:
> On 2011-02-05 10:27, Michael Tokarev wrote:
>> When compiling on i386 (32bit) compiler choles on this:
>>
>>   CC    x86_64-softmmu/helper.o
>> cc1: warnings being treated as errors
>> target-i386/helper.c: In function 'cpu_inject_x86_mce':
>> target-i386/helper.c:1153: error: integer constant is too large for 'long' type
>>
>> qemu_inject_x86_mce() accepts uint64_t as 3rd arg, so we have to add ULL
>> to fix the invocation.
>>
>> Signed-Off-By: Michael Tokarev <mjt@tls.msk.ru>
>>
>> --- a/target-i386/helper.c
>> +++ b/target-i386/helper.c
>> @@ -1152,3 +1152,3 @@
>>  
>> -                qemu_inject_x86_mce(env, 1, 0xa000000000000000, 0, 0, 0);
>> +                qemu_inject_x86_mce(env, 1, 0xa000000000000000ULL, 0, 0, 0);
>>              }
>>
> 
> The original value is wrong. [1] should get merged into 0.14.
> 
> Jan
> 
> [1] http://article.gmane.org/gmane.comp.emulators.kvm.devel/67445
>