From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=51055 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PmjKg-0006iD-99
	for qemu-devel@nongnu.org; Tue, 08 Feb 2011 03:53:59 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1PmjKR-0007B3-D9
	for qemu-devel@nongnu.org; Tue, 08 Feb 2011 03:53:44 -0500
Received: from david.siemens.de ([192.35.17.14]:33238)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1PmjKR-0007At-2w
	for qemu-devel@nongnu.org; Tue, 08 Feb 2011 03:53:43 -0500
Message-ID: <4D510490.8080201@siemens.com>
Date: Tue, 08 Feb 2011 09:53:36 +0100
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <1295902845-29807-1-git-send-email-aliguori@us.ibm.com>
	<1295902845-29807-2-git-send-email-aliguori@us.ibm.com>
In-Reply-To: <1295902845-29807-2-git-send-email-aliguori@us.ibm.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 1/7] io-thread: make sure to initialize
 qemu_work_cond and qemu_cpu_cond
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, Marcelo Tosatti <mtosatti@redhat.com>, qemu-devel@nongnu.org, Paul Brook <paul@codesourcery.com>, Arun Bharadwaj <arun@linux.vnet.ibm.com>, Paulo Bonzini <pbonzini@redhat.com>

On 2011-01-24 22:00, Anthony Liguori wrote:
> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
> 
> diff --git a/cpus.c b/cpus.c
> index 0309189..9cf7e6e 100644
> --- a/cpus.c
> +++ b/cpus.c
> @@ -412,8 +412,10 @@ int qemu_init_main_loop(void)
>      if (ret)
>          return ret;
>  
> -    qemu_cond_init(&qemu_pause_cond);
> +    qemu_cond_init(&qemu_cpu_cond);
>      qemu_cond_init(&qemu_system_cond);
> +    qemu_cond_init(&qemu_pause_cond);
> +    qemu_cond_init(&qemu_work_cond);
>      qemu_mutex_init(&qemu_fair_mutex);
>      qemu_mutex_init(&qemu_global_mutex);
>      qemu_mutex_lock(&qemu_global_mutex);

Please merge this independently of the glib patches. It's apparently
harmless only by chance so far.

Thanks,
Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux